<div class="gmail_quote">On Fri, Jun 8, 2012 at 11:58 AM, Manman Ren <span dir="ltr"><<a href="mailto:mren@apple.com" target="_blank">mren@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: mren<br>
Date: Fri Jun  8 13:58:26 2012<br>
New Revision: 158220<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=158220&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=158220&view=rev</a><br>
Log:<br>
Enable optimization for integer ABS on X86 if Subtarget has CMOV.<br></blockquote><div><br></div><div>Can you include a trivial test case by specifying i386 target CPU?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
Modified:<br>
    llvm/trunk/lib/Target/X86/X86ISelLowering.cpp<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86ISelLowering.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=158220&r1=158219&r2=158220&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86ISelLowering.cpp?rev=158220&r1=158219&r2=158220&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86ISelLowering.cpp (original)<br>
+++ llvm/trunk/lib/Target/X86/X86ISelLowering.cpp Fri Jun  8 13:58:26 2012<br>
@@ -14548,9 +14548,11 @@<br>
   if (DCI.isBeforeLegalizeOps())<br>
     return SDValue();<br>
<br>
-  SDValue RV = performIntegerAbsCombine(N, DAG);<br>
-  if (RV.getNode())<br>
-    return RV;<br>
+  if (Subtarget->hasCMov()) {<br>
+    SDValue RV = performIntegerAbsCombine(N, DAG);<br>
+    if (RV.getNode())<br>
+      return RV;<br>
+  }<br>
<br>
   // Try forming BMI if it is available.<br>
   if (!Subtarget->hasBMI())<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br>