<div class="gmail_quote">On Wed, Jun 6, 2012 at 6:53 PM, Nick Kledzik <span dir="ltr"><<a href="mailto:kledzik@apple.com" target="_blank">kledzik@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: kledzik<br>
Date: Wed Jun  6 20:53:39 2012<br>
New Revision: 158134<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=158134&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=158134&view=rev</a><br>
Log:<br>
fix warnings found after cranking up warnings<br>
<br>
Modified:<br>
    lld/trunk/include/lld/Core/File.h<br>
    lld/trunk/include/lld/Core/Pass.h<br>
    lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp<br>
    lld/trunk/lib/ReaderWriter/YAML/ReaderYAML.cpp<br>
<br>
Modified: lld/trunk/include/lld/Core/File.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/File.h?rev=158134&r1=158133&r2=158134&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/File.h?rev=158134&r1=158133&r2=158134&view=diff</a><br>

==============================================================================<br>
--- lld/trunk/include/lld/Core/File.h (original)<br>
+++ lld/trunk/include/lld/Core/File.h Wed Jun  6 20:53:39 2012<br>
@@ -110,6 +110,7 @@<br>
   template <typename T><br>
   class atom_collection {<br>
   public:<br>
+    virtual ~atom_collection() { }<br>
     virtual atom_iterator<T> begin() const = 0;<br>
     virtual atom_iterator<T> end() const = 0;<br>
     virtual const T* deref(const void* it) const = 0;<br>
<br>
Modified: lld/trunk/include/lld/Core/Pass.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/Pass.h?rev=158134&r1=158133&r2=158134&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/include/lld/Core/Pass.h?rev=158134&r1=158133&r2=158134&view=diff</a><br>

==============================================================================<br>
--- lld/trunk/include/lld/Core/Pass.h (original)<br>
+++ lld/trunk/include/lld/Core/Pass.h Wed Jun  6 20:53:39 2012<br>
@@ -34,6 +34,8 @@<br>
 ///<br>
 class Pass {<br>
 public:<br>
+  virtual ~Pass() { }<br>
+<br>
     /// Do the actual work of the Pass.<br>
     virtual void perform(File& mergedFile) = 0;<br>
<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp?rev=158134&r1=158133&r2=158134&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp?rev=158134&r1=158133&r2=158134&view=diff</a><br>

==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp (original)<br>
+++ lld/trunk/lib/ReaderWriter/PECOFF/ReaderCOFF.cpp Wed Jun  6 20:53:39 2012<br>
@@ -22,9 +22,10 @@<br>
 #include <map><br>
 #include <vector><br>
<br>
-using namespace lld;<br>
 using llvm::object::coff_symbol;<br>
<br>
+namespace lld {<br>
+<br></blockquote><div><br></div><div>As this is in a '.cpp' file, shouldn't this be an anonymous namespace?</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

 class COFFAbsoluteAtom : public AbsoluteAtom {<br>
 public:<br>
   COFFAbsoluteAtom(const File &F, llvm::StringRef N, uint64_t V)<br>
@@ -376,9 +377,10 @@<br>
 };<br>
<br>
<br>
-<br>
 Reader* createReaderPECOFF(const ReaderOptionsPECOFF &options) {<br>
   return new ReaderCOFF(options);<br>
 }<br>
<br>
+} // namespace lld<br>
+<br>
<br>
<br>
Modified: lld/trunk/lib/ReaderWriter/YAML/ReaderYAML.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/YAML/ReaderYAML.cpp?rev=158134&r1=158133&r2=158134&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/lld/trunk/lib/ReaderWriter/YAML/ReaderYAML.cpp?rev=158134&r1=158133&r2=158134&view=diff</a><br>

==============================================================================<br>
--- lld/trunk/lib/ReaderWriter/YAML/ReaderYAML.cpp (original)<br>
+++ lld/trunk/lib/ReaderWriter/YAML/ReaderYAML.cpp Wed Jun  6 20:53:39 2012<br>
@@ -1197,9 +1197,9 @@<br>
 }<br>
<br>
<br>
-/// parseObjectText - Parse the specified YAML formatted MemoryBuffer<br>
+/// parseFile - Parse the specified YAML formatted MemoryBuffer<br>
 /// into lld::File object(s) and append each to the specified vector<File*>.<br>
-error_code parseFile(std::unique_ptr<MemoryBuffer> &mb,<br>
+static error_code parseFile(std::unique_ptr<MemoryBuffer> &mb,<br>
                       const ReaderOptionsYAML &options,<br>
                       std::vector<std::unique_ptr<File>> &result) {<br>
   llvm::SourceMgr       srcMgr;<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br>