<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
On 05/29/2012 08:32 PM, David Blaikie wrote:
<blockquote
cite="mid:CAENS6EtcWHOpP4erq0sGmd=WZqC-Ok6gNUn9mpZ8F8DCbOzrvA@mail.gmail.com"
type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
<br>
<br>
<div class="gmail_quote">On Tue, May 29, 2012 at 8:26 PM, reed
kotler <span dir="ltr"><<a moz-do-not-send="true"
href="mailto:rkotler@mips.com" target="_blank">rkotler@mips.com</a>></span>
wrote:<br>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
I made this simple python script to check for long lines and
lines with tabs.<br>
If it will be useful, I will add more of the style rules to
it.<br>
</blockquote>
<div><br>
</div>
<div>I can't speak for whether this is the sort of thing other
people will want added to the build, or the way it should be
done, but if it is/if you choose to use it yourself, it might
be good to add "trailing whitespace" as another thing to check
for.<br>
<br>
</div>
</div>
</blockquote>
I was going to add trailing whitespace check tomorrow. <br>
<br>
<blockquote
cite="mid:CAENS6EtcWHOpP4erq0sGmd=WZqC-Ok6gNUn9mpZ8F8DCbOzrvA@mail.gmail.com"
type="cite">
<div class="gmail_quote">
<div>[side note: to make such a check useful, we sort of would
need to have the codebase clean of violations to begin with
(or the tool would have to be smart enough to only flag based
on revision control-reported diffs) & some of the core
developers are a bit averse to making such a sweeping change
as it would taint the revision history for "svn blame"-like
tasks (though I don't think this is actually true - since both
svn and git can annotate/blame with whitespace ignorance.
Also, one of the problems with making the codebase clean is
that you can't then keep it clean - until you have a tool like
you've written/provided here, so perhaps that'll provide extra
motivation to do a full clean]</div>
</div>
</blockquote>
both git and svn have apis for doing more. if it's useful i can
expand there too.<br>
<br>
Would be also cool to add to clang directly many things which
require an AST in order to <br>
properly do. Many visual rules that we have for continuation lines
could be enforced for example<br>
without the need for human beings to check those things.<br>
<br>
Also, it would be possible to enforce global style conventions as
well as to allow override of<br>
them in c/c++ commants with a clang based tool.<br>
<br>
I hate doing work that robots should do and lots of the style
checking we do can be done by<br>
robots.<br>
<br>
<blockquote
cite="mid:CAENS6EtcWHOpP4erq0sGmd=WZqC-Ok6gNUn9mpZ8F8DCbOzrvA@mail.gmail.com"
type="cite">
<div class="gmail_quote">
<div> </div>
<blockquote class="gmail_quote" style="margin: 0pt 0pt 0pt
0.8ex; border-left: 1px solid rgb(204, 204, 204);
padding-left: 1ex;">
<br>
Default is 80 character maximum lines and checking for tabs.<br>
<br>
Usage: style_check.py arg1 arg2 ... argn [options]<br>
<br>
Options:<br>
-h, --help show this help message and exit<br>
--no-check-for-tabs don't check for tabs<br>
--no-check-line-length<br>
don't check line length<br>
--max-line-length=MAXLINELENGTH<br>
specify maximum line length<br>
</blockquote>
</div>
<br>
</blockquote>
<br>
</body>
</html>