<div class="gmail_quote">On Wed, May 23, 2012 at 1:18 AM, Stepan Dyatkovskiy <span dir="ltr"><<a href="mailto:stpworld@narod.ru" target="_blank">stpworld@narod.ru</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: dyatkovskiy<br>
Date: Wed May 23 03:18:26 2012<br>
New Revision: 157315<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=157315&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=157315&view=rev</a><br>
Log:<br>
PR1255(case ranges) related changes in Local Transformations.<br></blockquote><div><br></div><div>Please be a bit more descriptive in your commit logs.</div><div><br></div><div>What changes? What specifically motivates them?</div>
<div><br></div><div>Also, why don't we have a test case for this? Is it caught by existing tests with case ranges enabled in some form? How did you spot the bug? Etc...</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

<br>
<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Utils/Local.cpp<br>
<br>
Modified: llvm/trunk/lib/Transforms/Utils/Local.cpp<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/Local.cpp?rev=157315&r1=157314&r2=157315&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/Local.cpp?rev=157315&r1=157314&r2=157315&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Transforms/Utils/Local.cpp (original)<br>
+++ llvm/trunk/lib/Transforms/Utils/Local.cpp Wed May 23 03:18:26 2012<br>
@@ -169,16 +169,20 @@<br>
       // Otherwise, we can fold this switch into a conditional branch<br>
       // instruction if it has only one non-default destination.<br>
       SwitchInst::CaseIt FirstCase = SI->case_begin();<br>
-      Value *Cond = Builder.CreateICmpEQ(SI->getCondition(),<br>
-          FirstCase.getCaseValue(), "cond");<br>
-<br>
-      // Insert the new branch.<br>
-      Builder.CreateCondBr(Cond, FirstCase.getCaseSuccessor(),<br>
-                           SI->getDefaultDest());<br>
-<br>
-      // Delete the old switch.<br>
-      SI->eraseFromParent();<br>
-      return true;<br>
+      ConstantRangesSet CRS = FirstCase.getCaseValueEx();<br>
+      if (CRS.getNumItems() == 1 && CRS.isSingleNumber(0)) {<br>
+        Value *Cond = Builder.CreateICmpEQ(SI->getCondition(),<br>
+            CRS.getItem(0).Low, "cond");<br>
+<br>
+        // Insert the new branch.<br>
+        Builder.CreateCondBr(Cond, FirstCase.getCaseSuccessor(),<br>
+                             SI->getDefaultDest());<br>
+<br>
+        // Delete the old switch.<br>
+        SI->eraseFromParent();<br>
+        return true;<br>
+<br>
+      }<br>
     }<br>
     return false;<br>
   }<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br>