<div class="gmail_quote">On Wed, May 23, 2012 at 3:58 AM, Stepan Dyatkovskiy <span dir="ltr"><<a href="mailto:STPWORLD@narod.ru" target="_blank">STPWORLD@narod.ru</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div>Well. OK, sorry. This commit adds very-very small changes to Local.cpp. I just replaced usage of deprecated SwitchInst::getCaseValue  method with SwitchInst::getCaseValueEx. Logic stay the same, so no new unittests needed.</div>
</blockquote><div><br></div><div>Very cool.</div><div><br></div><div>For future reference, an example of how this would typically look in a commit log:</div><div><br></div><div>"""</div><div>Replace usage of deprecated SwitchInst::getCaseValue with SwitchInst::getCaseValueEx.</div>
<div><br></div><div>No functionality changed.</div><div>"""</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div>-Stepan.</div>
<div> </div><div> </div><div>23.05.2012, 12:32, "Chandler Carruth" <<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>>:</div><div class="HOEnZb"><div class="h5"><blockquote type="cite">
<div>On Wed, May 23, 2012 at 1:18 AM, Stepan Dyatkovskiy <span dir="ltr"><<a href="mailto:stpworld@narod.ru" target="_blank">stpworld@narod.ru</a>></span> wrote:<br><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid #cccccc;padding-left:1ex">
Author: dyatkovskiy<br> Date: Wed May 23 03:18:26 2012<br> New Revision: 157315<br> <br> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=157315&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=157315&view=rev</a><br>
 Log:<br> PR1255(case ranges) related changes in Local Transformations.</blockquote><div>Please be a bit more descriptive in your commit logs.</div><div>What changes? What specifically motivates them?</div><div>Also, why don't we have a test case for this? Is it caught by existing tests with case ranges enabled in some form? How did you spot the bug? Etc...</div>
<div> </div><blockquote style="margin:0pt 0pt 0pt 0.8ex;border-left:1px solid #cccccc;padding-left:1ex"><br> <br> Modified:<br>    llvm/trunk/lib/Transforms/Utils/Local.cpp<br> <br> Modified: llvm/trunk/lib/Transforms/Utils/Local.cpp<br>
 URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/Local.cpp?rev=157315&r1=157314&r2=157315&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Transforms/Utils/Local.cpp?rev=157315&r1=157314&r2=157315&view=diff</a><br>
 ==============================================================================<br> --- llvm/trunk/lib/Transforms/Utils/Local.cpp (original)<br> +++ llvm/trunk/lib/Transforms/Utils/Local.cpp Wed May 23 03:18:26 2012<br> @@ -169,16 +169,20 @@<br>
       // Otherwise, we can fold this switch into a conditional branch<br>       // instruction if it has only one non-default destination.<br>       SwitchInst::CaseIt FirstCase = SI->case_begin();<br> -      Value *Cond = Builder.CreateICmpEQ(SI->getCondition(),<br>
 -          FirstCase.getCaseValue(), "cond");<br> -<br> -      // Insert the new branch.<br> -      Builder.CreateCondBr(Cond, FirstCase.getCaseSuccessor(),<br> -                           SI->getDefaultDest());<br>
 -<br> -      // Delete the old switch.<br> -      SI->eraseFromParent();<br> -      return true;<br> +      ConstantRangesSet CRS = FirstCase.getCaseValueEx();<br> +      if (CRS.getNumItems() == 1 && CRS.isSingleNumber(0)) {<br>
 +        Value *Cond = Builder.CreateICmpEQ(SI->getCondition(),<br> +            CRS.getItem(0).Low, "cond");<br> +<br> +        // Insert the new branch.<br> +        Builder.CreateCondBr(Cond, FirstCase.getCaseSuccessor(),<br>
 +                             SI->getDefaultDest());<br> +<br> +        // Delete the old switch.<br> +        SI->eraseFromParent();<br> +        return true;<br> +<br> +      }<br>     }<br>     return false;<br>
   }<br> <br> <br> _______________________________________________<br> llvm-commits mailing list<br> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></blockquote>
</div></blockquote></div></div></blockquote></div><br>