Ah, I see. The commit notification is sent to list anyway, and it contains the same info. Got it.<div><br><div class="gmail_quote">On Mon, May 14, 2012 at 6:22 PM, Chandler Carruth <span dir="ltr"><<a href="mailto:chandlerc@google.com" target="_blank">chandlerc@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">FYI, no need to send out a code review request if you're comfortable submitting immediately...<div class="HOEnZb"><div class="h5">
<br><br><div class="gmail_quote">On Mon, May 14, 2012 at 7:00 AM, Dmitry Vyukov <span dir="ltr"><<a href="mailto:dvyukov@google.com" target="_blank">dvyukov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Author: dvyukov<br>
Date: Mon May 14 09:00:07 2012<br>
New Revision: 156758<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=156758&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=156758&view=rev</a><br>
Log:<br>
tsan: update output tests to race on heap memory<br>
Races on stack of main thread are problematic for COMPAT mapping, because it's not 1-to-1 and race addr is not properly mapped from shadow back to application memory.<br>
Update output tests to race heap memory.<br>
<br>
Modified:<br>
    compiler-rt/trunk/lib/tsan/output_tests/mop_with_offset.cc<br>
    compiler-rt/trunk/lib/tsan/output_tests/mop_with_offset2.cc<br>
<br>
Modified: compiler-rt/trunk/lib/tsan/output_tests/mop_with_offset.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/output_tests/mop_with_offset.cc?rev=156758&r1=156757&r2=156758&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/output_tests/mop_with_offset.cc?rev=156758&r1=156757&r2=156758&view=diff</a><br>


==============================================================================<br>
--- compiler-rt/trunk/lib/tsan/output_tests/mop_with_offset.cc (original)<br>
+++ compiler-rt/trunk/lib/tsan/output_tests/mop_with_offset.cc Mon May 14 09:00:07 2012<br>
@@ -17,14 +17,15 @@<br>
 }<br>
<br>
 int main() {<br>
-  int data = 42;<br>
-  fprintf(stderr, "ptr1=%p\n", &data);<br>
-  fprintf(stderr, "ptr2=%p\n", (char*)&data + 2);<br>
+  int *data = new int(42);<br>
+  fprintf(stderr, "ptr1=%p\n", data);<br>
+  fprintf(stderr, "ptr2=%p\n", (char*)data + 2);<br>
   pthread_t t[2];<br>
-  pthread_create(&t[0], NULL, Thread1, &data);<br>
-  pthread_create(&t[1], NULL, Thread2, &data);<br>
+  pthread_create(&t[0], NULL, Thread1, data);<br>
+  pthread_create(&t[1], NULL, Thread2, data);<br>
   pthread_join(t[0], NULL);<br>
   pthread_join(t[1], NULL);<br>
+  delete data;<br>
 }<br>
<br>
 // CHECK: ptr1=[[PTR1:0x[0-9,a-f]+]]<br>
<br>
Modified: compiler-rt/trunk/lib/tsan/output_tests/mop_with_offset2.cc<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/output_tests/mop_with_offset2.cc?rev=156758&r1=156757&r2=156758&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/tsan/output_tests/mop_with_offset2.cc?rev=156758&r1=156757&r2=156758&view=diff</a><br>


==============================================================================<br>
--- compiler-rt/trunk/lib/tsan/output_tests/mop_with_offset2.cc (original)<br>
+++ compiler-rt/trunk/lib/tsan/output_tests/mop_with_offset2.cc Mon May 14 09:00:07 2012<br>
@@ -17,14 +17,15 @@<br>
 }<br>
<br>
 int main() {<br>
-  int data = 42;<br>
-  fprintf(stderr, "ptr1=%p\n", &data);<br>
-  fprintf(stderr, "ptr2=%p\n", (char*)&data + 2);<br>
+  int *data = new int(42);<br>
+  fprintf(stderr, "ptr1=%p\n", data);<br>
+  fprintf(stderr, "ptr2=%p\n", (char*)data + 2);<br>
   pthread_t t[2];<br>
-  pthread_create(&t[0], NULL, Thread1, &data);<br>
-  pthread_create(&t[1], NULL, Thread2, &data);<br>
+  pthread_create(&t[0], NULL, Thread1, data);<br>
+  pthread_create(&t[1], NULL, Thread2, data);<br>
   pthread_join(t[0], NULL);<br>
   pthread_join(t[1], NULL);<br>
+  delete data;<br>
 }<br>
<br>
 // CHECK: ptr1=[[PTR1:0x[0-9,a-f]+]]<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br>
</div></div></blockquote></div><br></div>