<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
On 5/8/12 7:07 AM, Richard Osborne wrote:
<blockquote cite="mid:4FA90C7E.1070500@xmos.com" type="cite">
<meta http-equiv="Content-Type" content="text/html;
charset=ISO-8859-1">
On 08/05/12 11:29, Ralf Karrenberg wrote:
<blockquote cite="mid:4FA8F588.707@cdl.uni-saarland.de"
type="cite"> On 5/8/12 11:40 AM, Richard Osborne wrote:<br>
<blockquote cite="mid:4FA8EA0B.1000701@xmos.com" type="cite">
<blockquote
cite="mid:c55ba728-8f2d-4938-a248-3d3c3e266927@com"
type="cite">
<div class="moz-text-plain" wrap="true"
graphical-quote="true" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-unicode">
<pre wrap="">Cheers,
Ralf</pre>
</div>
<div class="moz-text-plain" wrap="true"
graphical-quote="true" style="font-family: -moz-fixed;
font-size: 12px;" lang="x-western">
<pre wrap=""> /// hasAddressTaken - returns true if there are any uses of this basic block
/// other than direct branches, switches, etc. to it.
- bool hasAddressTaken() const { return getSubclassDataFromValue() != 0; }
+ bool hasAddressTaken() const {
+ return (getSubclassDataFromValue() & ~HasMetadataBit) != 0;
+ }
</pre>
</div>
</blockquote>
I think this will result in basic block metadata effecting
optimizations. What would happen if you just ignored metadata
here?<br>
</blockquote>
It will always treat a block that has metadata attached as a
block whose address has been taken, which results in a crash at
a later point (don't remember exactly where) because the address
was never taken.<br>
</blockquote>
</blockquote>
<br>
I think you might want to update the comment explaining what you
said above and providing a justification for it. Developers
misunderstanding code seems like a flag for a better comment, IMHO.<br>
<br>
-- John T.<br>
<br>
<blockquote cite="mid:4FA90C7E.1070500@xmos.com" type="cite">
<blockquote cite="mid:4FA8F588.707@cdl.uni-saarland.de"
type="cite"> </blockquote>
Ah sorry, I totally misread this bit of the code. It looks fine to
me.<br>
</blockquote>
<br>
<br>
<blockquote cite="mid:4FA90C7E.1070500@xmos.com" type="cite"> <br>
<pre class="moz-signature" cols="72">--
Richard Osborne | XMOS
<a moz-do-not-send="true" class="moz-txt-link-freetext" href="http://www.xmos.com">http://www.xmos.com</a>
</pre>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>