<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
Andy, <br>
<br>
Could you please review the patch and let me know if it's good to be
committed? This patch is a pre-req for the rest of the Hexagon
patches. <br>
<br>
ping :-) <br>
<br>
Thanks.<br>
Sirish<br>
<br>
On 4/25/2012 1:36 PM, Sirish Pande wrote:
<blockquote cite="mid:4F984449.2070901@codeaurora.org" type="cite">Hi
Andy,
<br>
<br>
I tried using MISUnits map but it requires more work than I
estimated - given that we use the map created in DFAPacketizer.cpp
is used extensively in our HexagonVLIWPacketizer.cpp.
<br>
So, I was wondering if I could just commit the patch with the map
created in DFAPacketizer.cpp. It still incorporates all the other
suggestions that you have made.
<br>
<br>
I will have another patch down the line that will use your mapping
functionality. I think another patch is good place for it because
that patch will have some rework of DFAPacketizer as
ScheduleDAGInstrs.h is in the include directory now. In the
rework of DFAPacketizer, we don't need to create an instance of
DefaultVLIWScheduler in the ctor of VLIWPacketizerList. That will
make things much simpler.
<br>
<br>
Let me know what you think. Also I have attached for your review.
<br>
<br>
Sirish
<br>
<br>
On 4/24/2012 3:49 PM, Andrew Trick wrote:
<br>
<blockquote type="cite">On Apr 24, 2012, at 11:43 AM, Sirish
Pande<a class="moz-txt-link-rfc2396E" href="mailto:spande@codeaurora.org"><spande@codeaurora.org></a> wrote:
<br>
<br>
<blockquote type="cite">I have attached Target Independent fix
required for Hexagon VLIW packetizer.
<br>
<br>
Like Andrew suggested, it does not have any warnings, make
check-all passes all test cases for *all* targets.
<br>
<br>
I have also incorporated Andrew's suggestions like moving
exitRegion after packetization, using finishBlock and using
map mi to su functionality.
<br>
<br>
Please review. And, if there are any questions or comments,
please let me know.
<br>
</blockquote>
Thanks for copying me.
<br>
<br>
I don't understand why you need to call initSUnits. That's
supposed to be a helper for buildSchedGraph. Any reason you
can't use the MISUnits map that it creates?
<br>
<br>
If you can just remove that call and everything works, then go
ahead and commit.
<br>
<br>
-Andy
<br>
<br>
<blockquote type="cite">
<br>
-- <br>
Qualcomm Innovation Center, Inc is a member of Code Aurora
Forum
<br>
<br>
<HexagonPacketizerTargetIndependentFix.patch>
<br>
</blockquote>
</blockquote>
<br>
<br>
<br>
<fieldset class="mimeAttachmentHeader"></fieldset>
<br>
<pre wrap="">_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
<br>
<pre class="moz-signature" cols="72">--
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum</pre>
</body>
</html>