On 27 April 2012 00:31, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com" target="_blank">kcc@google.com</a>></span> wrote:<br><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

Author: kcc<br>
Date: Fri Apr 27 02:31:53 2012<br>
New Revision: 155698<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=155698&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=155698&view=rev</a><br>
Log:<br>
[tsan] Atomic support for ThreadSanitizer, patch by  Dmitry Vyukov<br>
<br>
Added:<br>
    llvm/trunk/test/Instrumentation/ThreadSanitizer/atomic.ll<br>
Modified:<br>
    llvm/trunk/lib/Transforms/Instrumentation/ThreadSanitizer.cpp<br>
<br></blockquote><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">+static bool isAtomic(Instruction *I) {<br>
+  if (LoadInst *LI = dyn_cast<LoadInst>(I))<br>
+    return LI->isAtomic() && LI->getSynchScope() == CrossThread;<br>
+  else if (StoreInst *SI = dyn_cast<StoreInst>(I))<br>
+    return SI->isAtomic() && SI->getSynchScope() == CrossThread;<br>
+  else if (isa<AtomicRMWInst>(I))<br>
+    return true;<br>
+  else if (isa<AtomicCmpXchgInst>(I))<br>
+    return true;<br>
+  else if (FenceInst *FI = dyn_cast<FenceInst>(I))<br>
+    return FI->getSynchScope() == CrossThread;<br>
+  return false;<br>
+}<br></blockquote><div><br></div><div>Style nitpick: don't use else after return. <a href="http://llvm.org/docs/CodingStandards.html#hl_else_after_return">http://llvm.org/docs/CodingStandards.html#hl_else_after_return</a></div>

<div></div></div><br><div>Nick</div><div><br></div>