<div class="gmail_quote">On Wed, Apr 25, 2012 at 9:27 AM, Nick Kledzik <span dir="ltr"><<a href="mailto:kledzik@apple.com">kledzik@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="HOEnZb"><div class="h5"><br>
On Apr 25, 2012, at 5:53 AM, Jay Foad wrote:<br>
> Hi,<br>
><br>
> When building lld with gcc (Ubuntu/Linaro 4.6.1-9ubuntu3) 4.6.1 I get:<br>
><br>
> [100%] Building CXX object<br>
> projects/lld/lib/Platforms/Darwin/CMakeFiles/lldDarwinPlatform.dir/ExecutableWriter.cpp.o<br>
> /home/jay/svn/llvm-project/llvm/trunk/projects/lld/lib/Platforms/Darwin/ExecutableWriter.cpp:338:3:<br>
> error: a class-key must be used when declaring a friend<br>
> /home/jay/svn/llvm-project/llvm/trunk/projects/lld/lib/Platforms/Darwin/ExecutableWriter.cpp:338:3:<br>
> error: friend declaration does not name a class or function<br>
> /home/jay/svn/llvm-project/llvm/trunk/projects/lld/lib/Platforms/Darwin/ExecutableWriter.cpp:339:3:<br>
> error: a class-key must be used when declaring a friend<br>
> /home/jay/svn/llvm-project/llvm/trunk/projects/lld/lib/Platforms/Darwin/ExecutableWriter.cpp:339:3:<br>
> error: friend declaration does not name a class or function<br>
><br>
> The attached patch fixes this. OK to commit?<br>
</div></div>Yes.<br></blockquote><div><br></div><div>This is a C++11 feature (which apparently g++4.6 does not support). I have no idea whether lld intends to support g++4.6.</div><div><br></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

Is this something clang should be warning about too?</blockquote><div><br></div><div>It does, under -Wc++98-compat.</div></div>