<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Thanks for the review. Fixed in 155461.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Now when the vbroadcast sequence is unavailable the code looks like this:<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> movl (%rdi), %eax<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> vmovd %eax, %xmm0<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"> vpshufd $0, %xmm0, %xmm0<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Craig Topper [mailto:craig.topper@gmail.com]
<br>
<b>Sent:</b> Tuesday, April 24, 2012 17:59<br>
<b>To:</b> Rotem, Nadav<br>
<b>Cc:</b> llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> Re: [llvm-commits] [llvm] r155437 - in /llvm/trunk: lib/Target/X86/X86InstrSSE.td test/CodeGen/X86/avx2-vbroadcast.ll<o:p></o:p></span></p>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal" style="margin-bottom:12.0pt">Why do we need a pattern for 2f64? There's not a load version of that type. Also don't you need integer versions?<o:p></o:p></p>
<div>
<p class="MsoNormal">On Tue, Apr 24, 2012 at 4:07 AM, Nadav Rotem <<a href="mailto:nadav.rotem@intel.com" target="_blank">nadav.rotem@intel.com</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal">Author: nadav<br>
Date: Tue Apr 24 06:07:03 2012<br>
New Revision: 155437<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=155437&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=155437&view=rev</a><br>
Log:<br>
AVX: We lower VECTOR_SHUFFLE and BUILD_VECTOR nodes into vbroadcast instructions<br>
using the pattern (vbroadcast (i32load src)). In some cases, after we generate<br>
this pattern new users are added to the load node, which prevent the selection<br>
of the blend pattern. This commit provides fallback patterns which perform<br>
in-vector broadcast (using in-vector vbroadcast in AVX2 and pshufd on AVX1).<br>
<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/X86/X86InstrSSE.td<br>
llvm/trunk/test/CodeGen/X86/avx2-vbroadcast.ll<br>
<br>
Modified: llvm/trunk/lib/Target/X86/X86InstrSSE.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrSSE.td?rev=155437&r1=155436&r2=155437&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/X86/X86InstrSSE.td?rev=155437&r1=155436&r2=155437&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/X86/X86InstrSSE.td (original)<br>
+++ llvm/trunk/lib/Target/X86/X86InstrSSE.td Tue Apr 24 06:07:03 2012<br>
@@ -7723,6 +7723,20 @@<br>
(VPBROADCASTQrm addr:$src)>;<br>
def : Pat<(v4i64 (X86VBroadcast (loadi64 addr:$src))),<br>
(VPBROADCASTQYrm addr:$src)>;<br>
+<br>
+ // Provide fallback in case the load node that is used in the patterns above<br>
+ // is used by additional users, which prevents the pattern selection.<br>
+ let AddedComplexity = 20 in {<br>
+ def : Pat<(v4f32 (X86VBroadcast FR32:$src)),<br>
+ (VBROADCASTSSrr<br>
+ (INSERT_SUBREG (v4f32 (IMPLICIT_DEF)), FR32:$src, sub_ss))>;<br>
+ def : Pat<(v8f32 (X86VBroadcast FR32:$src)),<br>
+ (VBROADCASTSSYrr<br>
+ (INSERT_SUBREG (v4f32 (IMPLICIT_DEF)), FR32:$src, sub_ss))>;<br>
+ def : Pat<(v4f64 (X86VBroadcast FR64:$src)),<br>
+ (VBROADCASTSDrr<br>
+ (INSERT_SUBREG (v2f64 (IMPLICIT_DEF)), FR64:$src, sub_sd))>;<br>
+ }<br>
}<br>
<br>
// AVX1 broadcast patterns<br>
@@ -7735,11 +7749,38 @@<br>
(VBROADCASTSSYrm addr:$src)>;<br>
def : Pat<(v4f64 (X86VBroadcast (loadf64 addr:$src))),<br>
(VBROADCASTSDrm addr:$src)>;<br>
-<br>
def : Pat<(v4f32 (X86VBroadcast (loadf32 addr:$src))),<br>
(VBROADCASTSSrm addr:$src)>;<br>
def : Pat<(v4i32 (X86VBroadcast (loadi32 addr:$src))),<br>
(VBROADCASTSSrm addr:$src)>;<br>
+<br>
+ // Provide fallback in case the load node that is used in the patterns above<br>
+ // is used by additional users, which prevents the pattern selection.<br>
+ let AddedComplexity = 20 in {<br>
+ // 128bit broadcasts:<br>
+ def : Pat<(v2f64 (X86VBroadcast FR64:$src)),<br>
+ (VPSHUFDri<br>
+ (INSERT_SUBREG (v2f64 (IMPLICIT_DEF)), FR64:$src, sub_sd), 0)>;<br>
+ def : Pat<(v4f32 (X86VBroadcast FR32:$src)),<br>
+ (VPSHUFDri<br>
+ (INSERT_SUBREG (v4f32 (IMPLICIT_DEF)), FR32:$src, sub_ss), 0)>;<br>
+ def : Pat<(v8f32 (X86VBroadcast FR32:$src)),<br>
+ (VINSERTF128rr (INSERT_SUBREG (v8f32 (IMPLICIT_DEF)),<br>
+ (VPSHUFDri<br>
+ (INSERT_SUBREG (v4f32 (IMPLICIT_DEF)), FR32:$src, sub_ss), 0),<br>
+ sub_xmm),<br>
+ (VPSHUFDri<br>
+ (INSERT_SUBREG (v4f32 (IMPLICIT_DEF)), FR32:$src, sub_ss),<br>
+ 0), 1)>;<br>
+ def : Pat<(v4f64 (X86VBroadcast FR64:$src)),<br>
+ (VINSERTF128rr (INSERT_SUBREG (v4f64 (IMPLICIT_DEF)),<br>
+ (VPSHUFDri<br>
+ (INSERT_SUBREG (v2f64 (IMPLICIT_DEF)), FR64:$src, sub_sd), 0),<br>
+ sub_xmm),<br>
+ (VPSHUFDri<br>
+ (INSERT_SUBREG (v2f64 (IMPLICIT_DEF)), FR64:$src, sub_sd),<br>
+ 0), 1)>;<br>
+ }<br>
}<br>
<br>
//===----------------------------------------------------------------------===//<br>
<br>
Modified: llvm/trunk/test/CodeGen/X86/avx2-vbroadcast.ll<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/avx2-vbroadcast.ll?rev=155437&r1=155436&r2=155437&view=diff" target="_blank">
http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/X86/avx2-vbroadcast.ll?rev=155437&r1=155436&r2=155437&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/test/CodeGen/X86/avx2-vbroadcast.ll (original)<br>
+++ llvm/trunk/test/CodeGen/X86/avx2-vbroadcast.ll Tue Apr 24 06:07:03 2012<br>
@@ -160,6 +160,15 @@<br>
ret <8 x i32> %g<br>
}<br>
<br>
+; CHECK: V113<br>
+; CHECK: vbroadcastss<br>
+; CHECK: ret<br>
+define <8 x float> @V113(<8 x float> %in) nounwind uwtable readnone ssp {<br>
+entry:<br>
+ %g = fadd <8 x float> %in, <float 0xbf80000000000000, float 0xbf80000000000000, float 0xbf80000000000000, float 0xbf80000000000000, float 0xbf80000000000000, float 0xbf80000000000000, float 0xbf80000000000000, float 0xbf80000000000000><br>
+ ret <8 x float> %g<br>
+}<br>
+<br>
; CHECK: _e2<br>
; CHECK: vbroadcastss<br>
; CHECK: ret<br>
@@ -179,9 +188,37 @@<br>
%vecinit1.i = insertelement <8 x i8> %vecinit0.i, i8 52, i32 1<br>
%vecinit2.i = insertelement <8 x i8> %vecinit1.i, i8 52, i32 2<br>
%vecinit3.i = insertelement <8 x i8> %vecinit2.i, i8 52, i32 3<br>
- %vecinit4.i = insertelement <8 x i8> %vecinit3.i, i8 52, i32 3<br>
- %vecinit5.i = insertelement <8 x i8> %vecinit4.i, i8 52, i32 3<br>
- %vecinit6.i = insertelement <8 x i8> %vecinit5.i, i8 52, i32 3<br>
- %vecinit7.i = insertelement <8 x i8> %vecinit6.i, i8 52, i32 3<br>
+ %vecinit4.i = insertelement <8 x i8> %vecinit3.i, i8 52, i32 4<br>
+ %vecinit5.i = insertelement <8 x i8> %vecinit4.i, i8 52, i32 5<br>
+ %vecinit6.i = insertelement <8 x i8> %vecinit5.i, i8 52, i32 6<br>
+ %vecinit7.i = insertelement <8 x i8> %vecinit6.i, i8 52, i32 7<br>
ret <8 x i8> %vecinit7.i<br>
}<br>
+<br>
+<br>
+define void @crash() nounwind alwaysinline {<br>
+WGLoopsEntry:<br>
+ br i1 undef, label %ret, label %footer329VF<br>
+<br>
+footer329VF:<br>
+ %A.0.inVF = fmul float undef, 6.553600e+04<br>
+ %B.0.in407VF = fmul <8 x float> undef, <float 6.553600e+04, float 6.553600e+04, float 6.553600e+04, float 6.553600e+04, float 6.553600e+04, float 6.553600e+04, float 6.553600e+04, float 6.553600e+04><br>
+ %A.0VF = fptosi float %A.0.inVF to i32<br>
+ %B.0408VF = fptosi <8 x float> %B.0.in407VF to <8 x i32><br>
+ %0 = and <8 x i32> %B.0408VF, <i32 65535, i32 65535, i32 65535, i32 65535, i32 65535, i32 65535, i32 65535, i32 65535><br>
+ %1 = and i32 %A.0VF, 65535<br>
+ %temp1098VF = insertelement <8 x i32> undef, i32 %1, i32 0<br>
+ %vector1099VF = shufflevector <8 x i32> %temp1098VF, <8 x i32> undef, <8 x i32> zeroinitializer<br>
+ br i1 undef, label %preload1201VF, label %footer349VF<br>
+<br>
+preload1201VF:<br>
+ br label %footer349VF<br>
+<br>
+footer349VF:<br>
+ %2 = mul nsw <8 x i32> undef, %0<br>
+ %3 = mul nsw <8 x i32> undef, %vector1099VF<br>
+ br label %footer329VF<br>
+<br>
+ret:<br>
+ ret void<br>
+}<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><o:p></o:p></p>
</div>
<p class="MsoNormal"><br>
<br clear="all">
<br>
-- <br>
~Craig<o:p></o:p></p>
</div>
</div>
<font face="monospace">---------------------------------------------------------------------<br>
Intel Israel (74) Limited<br>
<br>
This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</font></body>
</html>