<html>
  <head>
    <meta content="text/html; charset=UTF-8" http-equiv="Content-Type">
  </head>
  <body bgcolor="#FFFFFF" text="#000000">
    On 4/23/2012 1:29 PM, Chandler Carruth wrote:
    <blockquote
cite="mid:CAGCO0KiD8Y8Pq0VHwGhWBzJdHR=p=8xpj91X_bT4qffTLtCF0Q@mail.gmail.com"
      type="cite">
      <div class="gmail_extra">
        <div class="gmail_quote">On Mon, Apr 23, 2012 at 11:09 AM,
          Sirish Pande <span dir="ltr"><<a moz-do-not-send="true"
              href="mailto:spande@codeaurora.org" target="_blank">spande@codeaurora.org</a>></span>
          wrote:<br>
          <blockquote class="gmail_quote" style="margin:0 0 0
            .8ex;border-left:1px #ccc solid;padding-left:1ex">
            <div bgcolor="#FFFFFF" text="#000000"> There were only two
              reviews:<br>
              <br>
              1. Eric C asked for test cases, and that test cases be
              associated with the patch.<br>
              2. Tom Stellard had requested to split the vliw packetizer
              patch.<br>
              <br>
              Both have been done.<br>
            </div>
          </blockquote>
          <div><br>
          </div>
          <div>But the review isn't finished yet. You need to wait for
            the reviewers to actually sign off on the change before
            submitting. The two comments you got were what people needed
            changed based on their first look, that doesn't mean the
            code is ready to be submitted yet.</div>
          <div><br>
          </div>
          <div>This patch is particularly problematic because it is not
            just changing the Hexagon, it's changing a core part of the
            codegen layer. Those changes need proper review before being
            committed, and that hasn't happened yet.</div>
          <div><br>
          </div>
          <div>I've reverted this patch until the review finishes
            because the patches requiring it had to be reverted anyways.</div>
          <div><br>
          </div>
          <div>I reverted the hexagon patches because your own
            regression tests failed for all of the patches in the
            series.</div>
          <div><br>
          </div>
          <div>This gets the tree back into both a reviewed and
            test-passing state. Let's keep it that way. =]</div>
        </div>
      </div>
    </blockquote>
    <br>
    Fair enough. I will wait for the reviewers for sign off.  <br>
    <br>
    <br>
    <pre class="moz-signature" cols="72">-- 
Qualcomm Innovation Center, Inc is a member of Code Aurora Forum</pre>
  </body>
</html>