<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=Windows-1252">
<meta name="Generator" content="Microsoft Word 12 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:"Cambria Math";
panose-1:2 4 5 3 5 4 6 3 2 4;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.hoenzb
{mso-style-name:hoenzb;}
span.EmailStyle18
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">I fixed all and committed the changes.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Thank you for reviewing this.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><b><i><span style="color:teal">- Elena</span></i></b><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p></o:p></span></p>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Craig Topper [mailto:craig.topper@gmail.com]
<br>
<b>Sent:</b> Saturday, April 21, 2012 09:57<br>
<b>To:</b> Chad Rosier<br>
<b>Cc:</b> Demikhovsky, Elena; llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> Re: [llvm-commits] Please Review: ZERO_EXTEND/SIGN_EXTEND/TRUNCATE optimization for AVX2<o:p></o:p></span></p>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<p class="MsoNormal" style="margin-bottom:12.0pt">The test case is full of windows line endings.<br>
<br>
+ // VPERMD<br>
+ int ShufMask[] = {0, 2, 4, 6, -1, -1, -1, -1};<br>
<br>
That should probably be "static const int ShufMask"<br>
<br>
<br>
+ int ShufMask[] = {0, 2, -1, -1};<br>
<br>
Same here. And only use 1 space after the comma.<br>
<br>
<br>
+ Op = DAG.getNode(X86ISD::PSHUFB, dl, MVT::v32i8, Op, BV);<br>
+ <br>
+ Op = DAG.getNode(ISD::BITCAST, dl, MVT::v4i64, Op);<br>
+<br>
+ int ShufMask[] = {0, 2, -1, -1};<br>
+ Op = DAG.getVectorShuffle(MVT::v4i64, dl, Op, DAG.getUNDEF(MVT::v4i64), &ShufMask[0]);<br>
+<br>
+ Op = DAG.getNode(ISD::EXTRACT_SUBVECTOR, dl, MVT::v2i64, Op, DAG.getIntPtrConstant(0));<br>
+ <br>
+ return DAG.getNode(ISD::BITCAST, dl, VT, Op);<br>
<br>
There are some dangling spaces in there. Also need to fit in 80 columns<br>
<br>
<br>
+ SDValue pshufbConstPool = DAG.getNode(ISD::BUILD_VECTOR, dl,<br>
+ MVT::v32i8, &pshufbMask[0], 32);<br>
<br>
This looks unused<br>
<br>
<br>
if (((VT == MVT::v8i32) && (OpVT == MVT::v8i16)) ||<br>
((VT == MVT::v4i64) && (OpVT == MVT::v4i32))) {<br>
<br>
This isn't your code, but can you fix the alignment so that the second line starts after the first line's opening parenthese.<br>
<br>
<br>
+let Predicates = [HasAVX2] in {<br>
+ let AddedComplexity = 15 in {<br>
+ def : Pat<(v4i64 (X86vzmovly (v4i32 VR128:$src))), (VPMOVZXDQYrr VR128:$src)>;<br>
+ def : Pat<(v8i32 (X86vzmovly (v8i16 VR128:$src))), (VPMOVZXWDYrr VR128:$src)>;<br>
+ }<br>
+}<br>
<br>
Why the AddedComplexity? Also 80 columns.<br>
<br>
<br>
+ AddToWorkList(Op.getNode());<br>
} else if (Op.getValueType().bitsGT(VT)) {<br>
Op = DAG.getNode(ISD::TRUNCATE, N->getDebugLoc(), VT, Op);<br>
- }<br>
+ AddToWorkList(Op.getNode());<br>
+ }<br>
<br>
Last bracket needs to be right 1 space.<br>
<br>
<o:p></o:p></p>
<div>
<p class="MsoNormal">On Thu, Apr 19, 2012 at 10:50 AM, Craig Topper <<a href="mailto:craig.topper@gmail.com">craig.topper@gmail.com</a>> wrote:<o:p></o:p></p>
<div>
<div>
<p class="MsoNormal">On Thu, Apr 19, 2012 at 10:29 AM, Chad Rosier <<a href="mailto:mcrosier@apple.com" target="_blank">mcrosier@apple.com</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal">Mostly stylistic comments:<br>
<br>
+ SmallVector<SDValue,32> pshufbMask;<br>
+ for (unsigned i=0; i<2; i++) {<br>
<br>
Spacing: for (unsigned i = 0; i < 2; i++)<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><br>
That should also be "++i" to match coding standards.<br>
<br>
I'll try to review the content tonight.<o:p></o:p></p>
</div>
</div>
<p class="MsoNormal"><span style="color:#888888"><br>
<span class="hoenzb">-- </span><br>
<span class="hoenzb">~Craig</span></span><o:p></o:p></p>
</div>
<p class="MsoNormal"><br>
<br clear="all">
<br>
-- <br>
~Craig<o:p></o:p></p>
</div>
<font face="monospace">---------------------------------------------------------------------<br>
Intel Israel (74) Limited<br>
<br>
This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</font></body>
</html>