<html><head><meta http-equiv="Content-Type" content="text/html charset=us-ascii"></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Apr 18, 2012, at 4:28 PM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="font-family: Optima; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; ">Because it is a phase-ordering kind of problem, I worry a lot about regressions. Specifically, if we ever get some other pass that nukes your "silly function", will we stop testing that this works?<br></div><div style="font-family: Optima; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><br></div><div style="font-family: Optima; font-size: medium; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; ">I wonder, could we add a direct test that SCEV can undrestand this pattern when InstCombine runs first? That would seem more targeted.</div></blockquote></div><br><div><span style="font-family: monospace; ">Committed as r155136, including test/Transforms/PhaseOrdering/scev.ll which runs all the standard passes followed by scalar evolution. It is used to test that certain expressions are not obfuscated by the optimizers.</span></div><div><span style="font-family: monospace; "><br></span></div><div><span style="font-family: monospace; ">/jakob</span></div><div><span style="font-family: monospace; "><br></span></div></body></html>