<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Mar 31, 2012, at 2:40 AM, Chandler Carruth <<a href="mailto:chandlerc@google.com">chandlerc@google.com</a>> wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Tiny coding style nits...<br><br><div class="gmail_quote">On Fri, Mar 30, 2012 at 6:35 PM, Andrew Trick <span dir="ltr"><<a href="mailto:atrick@apple.com">atrick@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">
<div id=":8cg">--- llvm/trunk/utils/TableGen/CodeGenRegisters.cpp (original)<br>
+++ llvm/trunk/utils/TableGen/CodeGenRegisters.cpp Fri Mar 30 20:35:59 2012<br>
@@ -88,6 +88,26 @@<br>
return TheDef->getName();<br>
}<br>
<br>
+// Merge two RegUnitLists maintining the order and removing duplicates.<br>
+// Overwrites MergedRU in the process.<br></div></blockquote><div><br></div><div>This worth a doxyment? We use them heavily on static functions in Clang, but I've seen both ways fly in LLVM...</div></div></blockquote><div><br></div><div>None of the tablegen code in this file is doxidized. Which is fine by me.</div><br><blockquote type="cite"><div class="gmail_quote"><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">
<div id=":8cg">
+static void mergeRegUnits(CodeGenRegister::RegUnitList &MergedRU,<br>
+ const CodeGenRegister::RegUnitList &RRU)<br>
+{</div></blockquote></div><br><div>curly brace should go after the close paren... at least, i think it fits there even w/ 80-columns...</div>
</blockquote><br></div><div>oops. done.</div><br><div>-Andy</div></body></html>