I would just disable these two globals -- they are used only for experiments right now. <div>Let me do the change. </div><div><br></div><div>--kcc <br><br><div class="gmail_quote">On Mon, Mar 19, 2012 at 3:00 AM,  <span dir="ltr"><<a href="mailto:samsonov@google.com">samsonov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Reviewers: kcc,<br>
<br>
<br>
<br>
Please review this at <a href="http://codereview.appspot.com/5844058/" target="_blank">http://codereview.appspot.com/5844058/</a><br>
<br>
Affected files:<br>
   M     lib/Transforms/Instrumentation/AddressSanitizer.cpp<br>
<br>
<br>
Index: lib/Transforms/Instrumentation/AddressSanitizer.cpp<br>
===================================================================<br>
--- lib/Transforms/Instrumentation/AddressSanitizer.cpp (revision 153031)<br>
+++ lib/Transforms/Instrumentation/AddressSanitizer.cpp (working copy)<br>
@@ -62,6 +62,7 @@<br>
  static const char *kAsanHandleNoReturnName = "__asan_handle_no_return";<br>
  static const char *kAsanMappingOffsetName = "__asan_mapping_offset";<br>
  static const char *kAsanMappingScaleName = "__asan_mapping_scale";<br>
+static const int   kAsanMappingConstantsAlignment = 1 << 5;<br>
  static const char *kAsanStackMallocName = "__asan_stack_malloc";<br>
  static const char *kAsanStackFreeName = "__asan_stack_free";<br>
<br>
@@ -584,10 +585,12 @@<br>
        new GlobalVariable(M, IntptrTy, true,<br>
GlobalValue::LinkOnceODRLinkage,<br>
                       ConstantInt::get(IntptrTy, MappingOffset),<br>
                       kAsanMappingOffsetName);<br>
+  asan_mapping_offset->setAlignment(kAsanMappingConstantsAlignment);<br>
    GlobalValue *asan_mapping_scale =<br>
        new GlobalVariable(M, IntptrTy, true,<br>
GlobalValue::LinkOnceODRLinkage,<br>
                           ConstantInt::get(IntptrTy, MappingScale),<br>
                           kAsanMappingScaleName);<br>
+  asan_mapping_scale->setAlignment(kAsanMappingConstantsAlignment);<br>
    // Read these globals, otherwise they may be optimized away.<br>
    IRB.CreateLoad(asan_mapping_scale, true);<br>
    IRB.CreateLoad(asan_mapping_offset, true);<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br></div>