<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:x="urn:schemas-microsoft-com:office:excel" xmlns:dt="uuid:C2F41010-65B3-11d1-A29F-00AA00C14882" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40">
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Word 14 (filtered medium)">
<style><!--
/* Font Definitions */
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:Tahoma;
panose-1:2 11 6 4 3 5 4 4 2 4;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:12.0pt;
font-family:"Times New Roman","serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
span.EmailStyle17
{mso-style-type:personal-reply;
font-family:"Calibri","sans-serif";
color:#1F497D;}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.25in 1.0in 1.25in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]-->
</head>
<body lang="EN-US" link="blue" vlink="purple">
<div class="WordSection1">
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Hi Nick,<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">The empty file is a leftover from the patch. I’ve removed it in r152703<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">As for the placement of the unit tests – we’ll take a look, thanks for noticing.<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D">Eli<o:p></o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<p class="MsoNormal"><span style="font-size:11.0pt;font-family:"Calibri","sans-serif";color:#1F497D"><o:p> </o:p></span></p>
<div style="border:none;border-left:solid blue 1.5pt;padding:0in 0in 0in 4.0pt">
<div>
<div style="border:none;border-top:solid #B5C4DF 1.0pt;padding:3.0pt 0in 0in 0in">
<p class="MsoNormal"><b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif"">From:</span></b><span style="font-size:10.0pt;font-family:"Tahoma","sans-serif""> Nick Lewycky [mailto:nlewycky@google.com]
<br>
<b>Sent:</b> Tuesday, March 13, 2012 23:00<br>
<b>To:</b> Bendersky, Eli<br>
<b>Cc:</b> llvm-commits@cs.uiuc.edu<br>
<b>Subject:</b> Re: [llvm-commits] [llvm] r152620 - in /llvm/trunk: ./ autoconf/ docs/ include/llvm/Config/ include/llvm/ExecutionEngine/ lib/ExecutionEngine/ lib/ExecutionEngine/IntelJITEvents/ lib/ExecutionEngine/JIT/ lib/ExecutionEngine/OProfileJIT/ tools/lli/
un<o:p></o:p></span></p>
</div>
</div>
<p class="MsoNormal"><o:p> </o:p></p>
<div>
<p class="MsoNormal">On 13 March 2012 01:33, Eli Bendersky <<a href="mailto:eli.bendersky@intel.com">eli.bendersky@intel.com</a>> wrote:<o:p></o:p></p>
<p class="MsoNormal">Author: eliben<br>
Date: Tue Mar 13 03:33:15 2012<br>
New Revision: 152620<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=152620&view=rev" target="_blank">
http://llvm.org/viewvc/llvm-project?rev=152620&view=rev</a><br>
Log:<br>
Add profiling support for Intel Parallel Amplifier XE (VTune) for JITted code in LLVM.<br>
<br>
Also refactor the existing OProfile profiling code to reuse the same interfaces with the VTune profiling code.<br>
In addition, unit tests for the profiling interfaces were added.<br>
<br>
This patch was prepared by Andrew Kaylor and Daniel Malea, and reviewed in the llvm-commits list by Jim Grosbach<br>
<br>
<br>
Added:<br>
llvm/trunk/include/llvm/ExecutionEngine/IntelJITEventsWrapper.h<br>
llvm/trunk/include/llvm/ExecutionEngine/OProfileWrapper.h<br>
llvm/trunk/lib/ExecutionEngine/EventListenerCommon.h<br>
llvm/trunk/lib/ExecutionEngine/IntelJITEvents/<br>
llvm/trunk/lib/ExecutionEngine/IntelJITEvents/CMakeLists.txt<br>
llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp<br>
llvm/trunk/lib/ExecutionEngine/IntelJITEvents/LLVMBuild.txt<br>
llvm/trunk/lib/ExecutionEngine/IntelJITEvents/Makefile<br>
llvm/trunk/lib/ExecutionEngine/OProfileJIT/<br>
llvm/trunk/lib/ExecutionEngine/OProfileJIT/CMakeLists.txt<br>
llvm/trunk/lib/ExecutionEngine/OProfileJIT/LLVMBuild.txt<br>
llvm/trunk/lib/ExecutionEngine/OProfileJIT/Makefile<br>
llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileJITEventListener.cpp<br>
llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileWrapper.cpp<br>
llvm/trunk/unittests/ExecutionEngine/IntelJITEventListenerTest.cpp<br>
llvm/trunk/unittests/ExecutionEngine/JITEventListenerTest.cpp<o:p></o:p></p>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">This is the first test in unittests/ExecutionEngine that relies on the JIT, the rest are all in ExecutionEngine/JIT. This is not a huge problem (it's just unit tests after all) so it's not a layering violation per se, but it is odd enough
that our build system noticed it.<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Is there any reason that test shouldn't be in the ExecutionEngine/JIT directory?<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Actually it looks like you left ExecutionEngine/JIT/JITEventListenerTest.cpp an empty file. Please fix!<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
<div>
<p class="MsoNormal">Nick<o:p></o:p></p>
</div>
<div>
<p class="MsoNormal"><o:p> </o:p></p>
</div>
</div>
</div>
</div>
<font face="monospace">---------------------------------------------------------------------<br>
Intel Israel (74) Limited<br>
<br>
This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</font></body>
</html>