<div class="gmail_quote">On 13 March 2012 01:33, Eli Bendersky <span dir="ltr"><<a href="mailto:eli.bendersky@intel.com">eli.bendersky@intel.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

Author: eliben<br>
Date: Tue Mar 13 03:33:15 2012<br>
New Revision: 152620<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=152620&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=152620&view=rev</a><br>
Log:<br>
Add profiling support for Intel Parallel Amplifier XE (VTune) for JITted code in LLVM.<br>
<br>
Also refactor the existing OProfile profiling code to reuse the same interfaces with the VTune profiling code.<br>
In addition, unit tests for the profiling interfaces were added.<br>
<br>
This patch was prepared by Andrew Kaylor and Daniel Malea, and reviewed in the llvm-commits list by Jim Grosbach<br>
<br>
<br>
Added:<br>
    llvm/trunk/include/llvm/ExecutionEngine/IntelJITEventsWrapper.h<br>
    llvm/trunk/include/llvm/ExecutionEngine/OProfileWrapper.h<br>
    llvm/trunk/lib/ExecutionEngine/EventListenerCommon.h<br>
    llvm/trunk/lib/ExecutionEngine/IntelJITEvents/<br>
    llvm/trunk/lib/ExecutionEngine/IntelJITEvents/CMakeLists.txt<br>
    llvm/trunk/lib/ExecutionEngine/IntelJITEvents/IntelJITEventListener.cpp<br>
    llvm/trunk/lib/ExecutionEngine/IntelJITEvents/LLVMBuild.txt<br>
    llvm/trunk/lib/ExecutionEngine/IntelJITEvents/Makefile<br>
    llvm/trunk/lib/ExecutionEngine/OProfileJIT/<br>
    llvm/trunk/lib/ExecutionEngine/OProfileJIT/CMakeLists.txt<br>
    llvm/trunk/lib/ExecutionEngine/OProfileJIT/LLVMBuild.txt<br>
    llvm/trunk/lib/ExecutionEngine/OProfileJIT/Makefile<br>
    llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileJITEventListener.cpp<br>
    llvm/trunk/lib/ExecutionEngine/OProfileJIT/OProfileWrapper.cpp<br>
    llvm/trunk/unittests/ExecutionEngine/IntelJITEventListenerTest.cpp<br>
    llvm/trunk/unittests/ExecutionEngine/JITEventListenerTest.cpp<br></blockquote><div><br></div><div>This is the first test in unittests/ExecutionEngine that relies on the JIT, the rest are all in ExecutionEngine/JIT. This is not a huge problem (it's just unit tests after all) so it's not a layering violation per se, but it is odd enough that our build system noticed it.</div>

<div><br></div><div>Is there any reason that test shouldn't be in the ExecutionEngine/JIT directory?</div><div><br></div><div>Actually it looks like you left ExecutionEngine/JIT/JITEventListenerTest.cpp an empty file. Please fix!</div>

<div><br></div><div>Nick</div><div><br></div></div>