<html xmlns:v="urn:schemas-microsoft-com:vml" xmlns:o="urn:schemas-microsoft-com:office:office" xmlns:w="urn:schemas-microsoft-com:office:word" xmlns:m="http://schemas.microsoft.com/office/2004/12/omml" xmlns="http://www.w3.org/TR/REC-html40"><head><META HTTP-EQUIV="Content-Type" CONTENT="text/html; charset=us-ascii"><meta name=Generator content="Microsoft Word 14 (filtered medium)"><style><!--
/* Font Definitions */
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:SimSun;
panose-1:2 1 6 0 3 1 1 1 1 1;}
@font-face
{font-family:Calibri;
panose-1:2 15 5 2 2 2 4 3 2 4;}
@font-face
{font-family:"\@SimSun";
panose-1:2 1 6 0 3 1 1 1 1 1;}
/* Style Definitions */
p.MsoNormal, li.MsoNormal, div.MsoNormal
{margin:0in;
margin-bottom:.0001pt;
font-size:11.0pt;
font-family:"Calibri","sans-serif";}
a:link, span.MsoHyperlink
{mso-style-priority:99;
color:blue;
text-decoration:underline;}
a:visited, span.MsoHyperlinkFollowed
{mso-style-priority:99;
color:purple;
text-decoration:underline;}
pre
{mso-style-priority:99;
mso-style-link:"HTML Preformatted Char";
margin:0in;
margin-bottom:.0001pt;
font-size:10.0pt;
font-family:"Courier New";}
span.EmailStyle17
{mso-style-type:personal-compose;
font-family:"Calibri","sans-serif";
color:windowtext;}
span.HTMLPreformattedChar
{mso-style-name:"HTML Preformatted Char";
mso-style-priority:99;
mso-style-link:"HTML Preformatted";
font-family:"Courier New";}
.MsoChpDefault
{mso-style-type:export-only;
font-family:"Calibri","sans-serif";}
@page WordSection1
{size:8.5in 11.0in;
margin:1.0in 1.0in 1.0in 1.0in;}
div.WordSection1
{page:WordSection1;}
--></style><!--[if gte mso 9]><xml>
<o:shapedefaults v:ext="edit" spidmax="1026" />
</xml><![endif]--><!--[if gte mso 9]><xml>
<o:shapelayout v:ext="edit">
<o:idmap v:ext="edit" data="1" />
</o:shapelayout></xml><![endif]--></head><body lang=EN-US link=blue vlink=purple><div class=WordSection1><p class=MsoNormal>The current definition of UMLAL/SMLAL in LLVM for ARM is not used and the<o:p></o:p></p><p class=MsoNormal>definition is not correct because the instruction reads the four values<o:p></o:p></p><p class=MsoNormal>as the input values instead of two values defined in the .td file.<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>I have created a bugzilla entry regarding to this issue:<o:p></o:p></p><p class=MsoNormal>http://llvm.org/bugs/show_bug.cgi?id=12213<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>I am proposing a patch not only fixed the definition but also added the corresponding <o:p></o:p></p><p class=MsoNormal>generation algorithm on DAG. This algorithm only operates on ARM backend. It identifies the <o:p></o:p></p><p class=MsoNormal>opportunity of conversions during DAG process. <o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>llmla.diff is the code change<o:p></o:p></p><p class=MsoNormal>longMAC.ll is the test case for ARM<o:p></o:p></p><p class=MsoNormal>longMACt.ll is the test case for Thumb2<o:p></o:p></p><p class=MsoNormal>report.simple.txt is the result from test-suites<o:p></o:p></p><p class=MsoNormal>result.txt is the result from test<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal>Please give a review. Thanks,<o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal> Yin <o:p></o:p></p><p class=MsoNormal><o:p> </o:p></p><p class=MsoNormal><o:p> </o:p></p></div></body></html>