I don't have commit access.<div><br></div><div>--Sean Silva<br><br><div class="gmail_quote">On Mon, Mar 5, 2012 at 2:04 PM, Bill Wendling <span dir="ltr"><<a href="mailto:wendling@apple.com">wendling@apple.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">Wow! The original code is wicked ugly. Your patch seems fine. If you have commit access, you can commit it.<br>
<br>
-bw<br>
<div><div class="h5"><br>
On Mar 4, 2012, at 8:23 AM, Sean Silva <<a href="mailto:silvas@purdue.edu">silvas@purdue.edu</a>> wrote:<br>
<br>
> The attached patch fixes these two warnings from clang:<br>
><br>
> /home/sean/pg/others/llvm/source/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4506:21: warning: adding 'bool' to a string does not append to the string [-Wstring-plus-int]<br>
>     return "_setjmp"+!TLI.usesUnderscoreSetJmp();<br>
>            ~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
> /home/sean/pg/others/llvm/source/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4506:21: note: use array indexing to silence this warning<br>
>     return "_setjmp"+!TLI.usesUnderscoreSetJmp();<br>
>                     ^<br>
>            &        [                           ]<br>
> /home/sean/pg/others/llvm/source/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4508:22: warning: adding 'bool' to a string does not append to the string [-Wstring-plus-int]<br>
>     return "_longjmp"+!TLI.usesUnderscoreLongJmp();<br>
>            ~~~~~~~~~~^~~~~~~~~~~~~~~~~~~~~~~~~~~~~<br>
> /home/sean/pg/others/llvm/source/lib/CodeGen/SelectionDAG/SelectionDAGBuilder.cpp:4508:22: note: use array indexing to silence this warning<br>
>     return "_longjmp"+!TLI.usesUnderscoreLongJmp();<br>
>                      ^<br>
>            &         [                            ]<br>
> 2 warnings generated.<br>
><br>
><br>
> --Sean Silva<br>
</div></div>> <unwarn.patch>_______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
</blockquote></div><br></div>