<!DOCTYPE HTML PUBLIC "-//W3C//DTD HTML 4.01 Transitional//EN">
<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#ffffff" text="#000000">
ok, let's add a little bit more context...<br>
<br>
some Makefiles generate a linker script.<br>
this should have the form <br>
{<br>
global:<br>
symbol1;<br>
symbol2;<br>
local: *;<br>
}<br>
it is generated from a file such as gold.exports, lto.exports which
contains a plain list of symbol names.<br>
Makefile.rules processes the list using grep, however it uses a
non-portable GNU extension for grep "\<" to detect whether<br>
the list contains a valid symbol name (or is empty) and only outputs
the global line in the former case.<br>
this grep usage fails using a grep command which uses only the POSIX
syntax, such as busybox grep.<br>
it will lead to global: missing, thus producing an incorrect linker
script.<br>
<br>
the previously attached patch was discussed in #llvm irc channel
with 3 regulars, and all found the patch to be acceptable.<br>
<br>
On 03/03/2012 12:58 AM, John Spencer wrote:
<blockquote cite="mid:4F515EA1.6050906@barfooze.de" type="cite">as
discussed on IRC, this patch changes the regex to a posix
compliant version, which works with busybox' grep.
<br>
<br>
<echristo> i have no objections. sounds like joe and
zygoloid actually have it in their sources if they want to push
it.
<br>
<br>
--JS
<br>
<br>
<pre wrap="">
<fieldset class="mimeAttachmentHeader"></fieldset>
_______________________________________________
llvm-commits mailing list
<a class="moz-txt-link-abbreviated" href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a>
<a class="moz-txt-link-freetext" href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a>
</pre>
</blockquote>
<br>
</body>
</html>