Sorry about that - I had stuck that in during development of this patch because tablegen was dying there complaining about opcode overlaps. But everything seems fine without that check now. <br><br>Updated patch attached.<br>
<br><div class="gmail_quote">On Thu, Feb 23, 2012 at 9:16 PM, Craig Topper <span dir="ltr"><<a href="mailto:craig.topper@gmail.com">craig.topper@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Why is this needed? If it is needed, please replace the tab characters at the beginning of the lines with spaces.<br><br>@@ -648,7 +657,10 @@<br>         if(newInfo.filtered)<br>           continue; // filtered instructions get lowest priority<br>

         <br>-        if(previousInfo.name == "NOOP" && (newInfo.name == "XCHG16ar" ||<br>+        if(previousInfo.name == "JCXZ" || previousInfo.name == "JECXZ_64") <br>+      continue; // AdSize prefix distinguishes between JCXZ/JECXZ/JRCXZ<br>

+    <br>+    if(previousInfo.name == "NOOP" && (newInfo.name == "XCHG16ar" ||<br>                                            newInfo.name == "XCHG32ar" ||<br>                                            newInfo.name == "XCHG32ar64" ||<br>

                                            newInfo.name == "XCHG64ar"))<br><br><br>Unfortunately, this increases disassembler table size, but there's no 
good way around that with the current design. Otherwise LGTM.<br><br>~Craig<br><br><div class="gmail_quote"><div><div class="h5">On Thu, Feb 23, 2012 at 7:10 PM, Kay Tiong Khoo <span dir="ltr"><<a href="mailto:kkhoo@perfwizard.com" target="_blank">kkhoo@perfwizard.com</a>></span> wrote:<br>

</div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div class="h5">The attached patch enables disassembly of JCXZ/JECXZ (i386) and JECXZ/JRCXZ (x86-64). See bug 11643 ( <a href="http://llvm.org/bugs/show_bug.cgi?id=11643" target="_blank">http://llvm.org/bugs/show_bug.cgi?id=11643</a> ) for more details.<br>



<br>It's not clear to me why these common instructions were marked with "isAsmParserOnly = 1", so I'm not sure if the changes in this patch are the best way to enable their disassembly. Please review and let me know. Thanks.<span><font color="#888888"><br>



<br>KK<br>
</font></span><br></div></div>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div>
</blockquote></div><br>