Ok.<br><br><div class="gmail_quote">On Wed, Feb 22, 2012 at 10:00 PM, Kostya Serebryany <span dir="ltr"><<a href="mailto:kcc@google.com">kcc@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Why do you need this macro at all if you are not using it? <div>I would actually ask to define </div><div> const uint64_t kMaxInt64 = ... </div><div>inside the module (or function) where you need it and get rid of all these macros completely. </div>
<div><br></div><div>--kcc <div><div class="h5"><br><br><div class="gmail_quote">On Wed, Feb 22, 2012 at 9:36 AM, Alexey Samsonov <span dir="ltr"><<a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Why do you think it's better here?<div><div><br><br><div class="gmail_quote">On Wed, Feb 22, 2012 at 8:25 PM, Timur Iskhodzhanov <span dir="ltr"><<a href="mailto:timurrrr@google.com" target="_blank">timurrrr@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">why not<br>
#ifndef INT32_MIN<br>
# define INT32_MIN ...<br>
#endif<br>
instead?<br>
<br>
<br>
On Wed, Feb 22, 2012 at 8:12 PM, Alexey Samsonov <<a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a>> wrote:<br>
> Author: samsonov<br>
> Date: Wed Feb 22 10:12:46 2012<br>
> New Revision: 151165<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=151165&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=151165&view=rev</a><br>
> Log:<br>
> AddressSanitizer: quick fix - undef INT32_MIN etc to avoid macro redefinition<br>
><br>
> Modified:<br>
> compiler-rt/trunk/lib/asan/asan_internal.h<br>
><br>
> Modified: compiler-rt/trunk/lib/asan/asan_internal.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_internal.h?rev=151165&r1=151164&r2=151165&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/asan_internal.h?rev=151165&r1=151164&r2=151165&view=diff</a><br>
> ==============================================================================<br>
> --- compiler-rt/trunk/lib/asan/asan_internal.h (original)<br>
> +++ compiler-rt/trunk/lib/asan/asan_internal.h Wed Feb 22 10:12:46 2012<br>
> @@ -68,12 +68,18 @@<br>
> # define __INT64_C(c) c ## LL<br>
> # define __UINT64_C(c) c ## ULL<br>
> #endif // __WORDSIZE == 64<br>
> -# define INT32_MIN (-2147483647-1)<br>
> -# define INT32_MAX <a href="tel:%282147483647" value="+12147483647" target="_blank">(2147483647</a>)<br>
> -# define UINT32_MAX (4294967295U)<br>
> -# define INT64_MIN (-__INT64_C(9223372036854775807)-1)<br>
> -# define INT64_MAX (__INT64_C(9223372036854775807))<br>
> -# define UINT64_MAX (__UINT64_C(18446744073709551615))<br>
> +#undef INT32_MIN<br>
> +#define INT32_MIN (-2147483647-1)<br>
> +#undef INT32_MAX<br>
> +#define INT32_MAX <a href="tel:%282147483647" value="+12147483647" target="_blank">(2147483647</a>)<br>
> +#undef UINT32_MAX<br>
> +#define UINT32_MAX (4294967295U)<br>
> +#undef INT64_MIN<br>
> +#define INT64_MIN (-__INT64_C(9223372036854775807)-1)<br>
> +#undef INT64_MAX<br>
> +#define INT64_MAX (__INT64_C(9223372036854775807))<br>
> +#undef UINT64_MAX<br>
> +#define UINT64_MAX (__UINT64_C(18446744073709551615))<br>
><br>
> #define ASAN_DEFAULT_FAILURE_EXITCODE 1<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br><br clear="all"><div><br></div></div></div><span><font color="#888888">-- <br><div>Alexey Samsonov</div><div>Software Engineer, Moscow</div><div><a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a></div>
<br>
</font></span><br>_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br></blockquote></div><br></div></div></div>
</blockquote></div><br><br clear="all"><div><br></div>-- <br><div>Alexey Samsonov</div><div>Software Engineer, Moscow</div><div><a href="mailto:samsonov@google.com" target="_blank">samsonov@google.com</a></div><br>