<br><br><div class="gmail_quote">On Mon, Feb 13, 2012 at 8:33 AM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="im">On Mon, Feb 13, 2012 at 4:36 AM, Evgeniy Stepanov<br>
<<a href="mailto:eugeni.stepanov@gmail.com">eugeni.stepanov@gmail.com</a>> wrote:<br>
> Author: eugenis<br>
> Date: Mon Feb 13 06:36:44 2012<br>
> New Revision: 150381<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=150381&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=150381&view=rev</a><br>
> Log:<br>
> [asan] Add a missing return.<br>
><br>
> It is technically reachable on Android, where pthread_exit is not<br>
> marked noreturn.<br>
<br>
</div>due to a bug in the header (ie: it should be annotated as noreturn but<br>
isn't) or a difference in behavior?<br>
<br>
llvm_unreachable might be a nicer choice </blockquote><div><br></div><div>This code does not include LLVM headers. </div><div><br></div><div>--kcc </div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
if it's still, really<br>
unreachable but some libraries inhibit the proof of that property. (I<br>
mention this because the return you added is the sort of thing that<br>
Clang's -Wunreachable-code warning would flag in the case where<br>
pthread_exit is a noreturn function)<br>
<span class="HOEnZb"><font color="#888888"><br>
- David<br>
</font></span><div class="HOEnZb"><div class="h5"><br>
><br>
> Modified:<br>
>    compiler-rt/trunk/lib/asan/tests/asan_test.cc<br>
><br>
> Modified: compiler-rt/trunk/lib/asan/tests/asan_test.cc<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/tests/asan_test.cc?rev=150381&r1=150380&r2=150381&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/compiler-rt/trunk/lib/asan/tests/asan_test.cc?rev=150381&r1=150380&r2=150381&view=diff</a><br>

> ==============================================================================<br>
> --- compiler-rt/trunk/lib/asan/tests/asan_test.cc (original)<br>
> +++ compiler-rt/trunk/lib/asan/tests/asan_test.cc Mon Feb 13 06:36:44 2012<br>
> @@ -1643,6 +1643,7 @@<br>
><br>
>  static void *PthreadExit(void *a) {<br>
>   pthread_exit(0);<br>
> +  return 0;<br>
>  }<br>
><br>
>  TEST(AddressSanitizer, PthreadExitTest) {<br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br>