Much better. <div>Now, how about using _AddressOfReturnAddress() for the frame? </div><div><br></div><div>--kcc <br><br><div class="gmail_quote">On Tue, Feb 7, 2012 at 9:56 AM, Timur Iskhodzhanov <span dir="ltr"><<a href="mailto:timurrrr@google.com">timurrrr@google.com</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">PTAL,<br>
though personally I don't like how it looks now.<br>
<div class="HOEnZb"><div class="h5"><br>
On Tue, Feb 7, 2012 at 9:36 PM, Kostya Serebryany <<a href="mailto:kcc@google.com">kcc@google.com</a>> wrote:<br>
><br>
><br>
> On Tue, Feb 7, 2012 at 4:51 AM, <<a href="mailto:timurrrr@google.com">timurrrr@google.com</a>> wrote:<br>
>><br>
>><br>
>> <a href="http://codereview.appspot.com/5630065/diff/1/lib/asan/asan_internal.h" target="_blank">http://codereview.appspot.com/5630065/diff/1/lib/asan/asan_internal.h</a><br>
>> File lib/asan/asan_internal.h (right):<br>
>><br>
>><br>
>> <a href="http://codereview.appspot.com/5630065/diff/1/lib/asan/asan_internal.h#newcode24" target="_blank">http://codereview.appspot.com/5630065/diff/1/lib/asan/asan_internal.h#newcode24</a><br>
>> lib/asan/asan_internal.h:24: # include <intrin.h><br>
>> On 2012/02/06 19:18:31, kcc wrote:<br>
>>><br>
>>> Can we avoid this include in the header?<br>
>>> ( I am not sure we can, just asking)<br>
>><br>
>> I doubt so.<br>
>> Or we'll need to #include it in every file which uses GET_CURRENT_PC or<br>
>> GET_BP_PC_SP.<br>
><br>
><br>
> Maybe you can find how this thing is defined in intrin.h and use similar<br>
> definition?<br>
><br>
><br>
> --kcc<br>
</div></div></blockquote></div><br></div>