I'll get those cleaned up.<br><br><div class="gmail_quote">On Sun, Feb 5, 2012 at 10:32 PM, David Blaikie <span dir="ltr"><<a href="mailto:dblaikie@gmail.com">dblaikie@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">

> Modified: llvm/trunk/include/llvm/CodeGen/ScheduleDAG.h<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/ScheduleDAG.h?rev=149849&r1=149848&r2=149849&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/include/llvm/CodeGen/ScheduleDAG.h?rev=149849&r1=149848&r2=149849&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/include/llvm/CodeGen/ScheduleDAG.h (original)<br>
> +++ llvm/trunk/include/llvm/CodeGen/ScheduleDAG.h Sun Feb  5 16:14:15 2012<br>
> @@ -128,9 +128,8 @@<br>
>                  Other.Contents.Order.isNormalMemory &&<br>
>                Contents.Order.isMustAlias == Other.Contents.Order.isMustAlias &&<br>
>                Contents.Order.isArtificial == Other.Contents.Order.isArtificial;<br>
> +      default: llvm_unreachable("Invalid dependency kind!");<br>
>       }<br>
> -      assert(0 && "Invalid dependency kind!");<br>
> -      return false;<br>
<br>
If you could keep trailing asserts like this as trailing (though feel<br>
free to convert them from assert to llvm_unreachable) that would be<br>
great. Adding a default to a fully-covered switch like this is<br>
unhelpful as it suppresses -Wswitch (which warns when a<br>
switch-over-enum is not fully covered) should a new element be added<br>
to the enumeration.<br>
<br>
Clang has a warning I recently added (-Wcovered-switch-default) that<br>
catches this case & your changes have caused several violations of<br>
this warning across LLVM.<br>
<br>
Let me know if you'd prefer me to fix them up.<br>
<br>
- David<br>
<br>
<br>
</blockquote></div><br>-- <br>~Craig<br>