Sounds good. I'll look in to that today.<div><br></div><div>- Lang.<br><br><div class="gmail_quote">On Thu, Feb 2, 2012 at 8:47 AM, Jakob Stoklund Olesen <span dir="ltr"><<a href="mailto:stoklund@2pi.dk">stoklund@2pi.dk</a>></span> wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div class="im"><br>
On Feb 2, 2012, at 12:01 AM, Lang Hames wrote:<br>
<br>
> Author: lhames<br>
> Date: Thu Feb  2 02:01:53 2012<br>
> New Revision: 149598<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=149598&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=149598&view=rev</a><br>
> Log:<br>
> Re-apply the coalescer fix from r149147. Commit r149597 should have fixed the llvm-gcc and clang self-host issues.<br>
><br>
> Modified:<br>
>    llvm/trunk/lib/CodeGen/RegisterCoalescer.cpp<br>
<br>
</div>Hi Lang,<br>
<br>
Ideally, this code would live in LiveRangeEdit, and the coalescer would use LRE to perform the remat. That way, you can also integrate instant dead code elimination:<br>
<br>
  LRE.remat(...);<br>
  LIS->shrinkToUses(SrcInt, DeadDefs);<br>
  LRE.eliminateDeadDefs(DeadDefs);<br>
<br>
This would allow us to get rid of the somewhat incomplete late dead code elimination in RegisterCoalescer.<br>
<span class="HOEnZb"><font color="#888888"><br>
/jakob<br>
<br>
</font></span></blockquote></div><br></div>