<div>
<p>Hi Mark,</p>
<p>Thanks for working on this!</p>
<p>Please CC the <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a> with your patches.</p>
<p>The patch looks Ok to me.<br>The only thing is the configure without any explicit parameter. Would it always choose the right things by default?</p>
<div>I'll commit this patch on Monday if no one will comment/object till then.</div>
<div> </div>
<div>Thanks</div>
<div> </div>
<div>Galina</div></div>
<div> </div>
<div> </div>
<div><br><br> </div>
<div class="gmail_quote">---------- Forwarded message ----------<br>From: <b class="gmail_sendername">Mark Peek</b> <span dir="ltr"><<a href="mailto:mark@peek.org">mark@peek.org</a>></span><br>Date: Wed, Jan 25, 2012 at 9:22 PM<br>
Subject: Re: Help with buildbot commit (was [PATCH] Change buildbot to patch lldb local changes)<br>To: Galina Kistanova <<a href="mailto:gkistanova@gmail.com">gkistanova@gmail.com</a>><br><br><br>Here's a version that appears to work both in and out of tree. I ran it twice out of tree and then twice in tree to verify.<br>
<br>Thanks,<br>Mark
<div class="im"><br><br>On 1/25/12 5:34 PM, Galina Kistanova wrote:<br></div>
<blockquote style="BORDER-LEFT:#ccc 1px solid;MARGIN:0px 0px 0px 0.8ex;PADDING-LEFT:1ex" class="gmail_quote">
<div class="im">That should be about the same. Just create a separate build/obj directory and<br>run configure from there as ../<src>/configure <all params you need>.<br>If both in and out will not work for any reason, I think, out of tree is<br>
preferable.<br>Good luck.<br>Thanks<br>Galina<br><br><br>On Wed, Jan 25, 2012 at 1:51 PM, Mark Peek <<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a><br></div>
<div class="im"><mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a>>> wrote:<br><br> The really short answer is because I didn't know any better about that<br> being the recommended way. Looking at the script it appears the in/out is<br>
dictated by how the factory is being called and most of the logic is<br> there. But there might be a bug in it where the configure really needs to<br> take into account the out of tree build. Let me take a look, see if I can<br>
get both in/out of tree working, and then get you a new patch.<br><br> Mark<br><br><br> On 1/25/12 12:56 PM, Galina Kistanova wrote:<br><br> Want to ask why do you build in tree? The recommended way is to<br>
build out of<br> tree.<br><br> Thanks<br><br> Galina<br> On Tue, Jan 24, 2012 at 10:28 PM, Mark Peek <<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a><br> <mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a>><br>
</div>
<div>
<div class="h5"> <mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a> <mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a>>>> wrote:<br><br> Galina,<br>
Attached is an updated patch which will remove the source,<br> checkout, patch<br> and build lldb. Passed twice in a row in my buildbot setup to make<br> sure it<br> worked correctly with a verification that the source directory got<br>
removed<br> in between runs.<br><br> Thanks,<br> Mark<br><br><br> On 1/24/12 9:28 AM, Mark Peek wrote:<br><br> Hi Galina,<br> Thank you for the response. I hadn't realized there was an<br>
issue with<br> svn revert and was trying to reduce the load on the svn<br> server. Let me<br> try redoing the patch to take that into account. Given my work<br> schedule I'll see if I can get to it later this week or the<br>
weekend at<br> the very latest.<br><br> Thanks,<br> Mark<br><br> On 1/23/12 1:35 PM, Galina Kistanova wrote:<br><br> Hi Mark,<br> Maybe it makes sense to remove the source and check out<br>
the clean<br> specific<br> revision instead of reverting lldb patches?<br> Unfortunatelly, svn<br> revert doesn’t<br> always do the job. The rest looks good enough.<br>
Thanks<br> Galina<br><br> On Sun, Jan 22, 2012 at 8:11 PM, Mark Peek <<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a><br> <mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a>><br>
<mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a> <mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a>>><br> <mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a> <mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a>> <mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a><br>
<mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a>>>>> wrote:<br><br> Hi Galina,<br> I posted the below change to lldb-commit that should<br>
help lldb<br> start<br> passing with the buildbot. But I haven't had any luck<br> getting<br> someone to<br> pick it up and commit it. I did follow up with both<br>
the last<br> person to<br> commit to it and to the lldb-dev list.<br><br> Would you be able to look at it and commit it? Or be<br> able to<br> suggest<br>
someone that would be able to?<br><br> Thanks,<br> Mark<br><br> -------- Original Message --------<br> Subject: [Lldb-commits] [PATCH] Change buildbot to<br>
patch lldb<br> local changes<br> Date: Sun, 08 Jan 2012 10:46:48 -0800<br> From: Mark Peek <<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a> <mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a>><br>
<mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a> <mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a>>><br> <mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a> <mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a>> <mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a><br>
<mailto:<a href="mailto:mark@peek.org" target="_blank">mark@peek.org</a>>>>><br> To: <a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.edu</a><br> <mailto:<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.<u></u>edu</a>> <mailto:<a href="mailto:lldb-commits@cs.uiuc." target="_blank">lldb-commits@cs.uiuc.</a>_<u></u>_edu<br>
<mailto:<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.<u></u>edu</a>>><br></div></div> <mailto:<a href="mailto:lldb-commits@cs.uiuc" target="_blank">lldb-commits@cs.uiuc</a>. <mailto:<a href="mailto:lldb-commits@cs.uiuc" target="_blank">lldb-commits@cs.uiuc</a>.><u></u>____edu
<div class="im"><br> <mailto:<a href="mailto:lldb-commits@cs.uiuc." target="_blank">lldb-commits@cs.uiuc.</a>_<u></u>_edu <mailto:<a href="mailto:lldb-commits@cs.uiuc.edu" target="_blank">lldb-commits@cs.uiuc.<u></u>edu</a>>>><br>
<br> The buildbot script for lldb does not apply local lldb<br> patches<br> from the<br> lldb/scripts directory which is currently causing<br> compilation<br>
errors and<br> failing the build. This patch will revert and reapply<br> the lldb<br> patches prior<br> to building to provide a more consistent build.<br>
<br> Note: this does stub out the test phase since that is<br> hanging<br> on my local<br> buildbot system. But it is probably better to get the<br> compile<br>
running<br> again on the buildbot to find build regressions and<br> then get<br> the tests<br> running later.<br><br> Mark<br>
<br><br><br><br><br><br><br></div></blockquote><br></div><br>