<div class="gmail_quote">On Tue, Jan 10, 2012 at 11:10 AM, Richard Smith <span dir="ltr"><<a href="mailto:richard-llvm@metafoo.co.uk">richard-llvm@metafoo.co.uk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: rsmith<br>
Date: Tue Jan 10 13:10:22 2012<br>
New Revision: 147867<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=147867&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=147867&view=rev</a><br>
Log:<br>
Fix a -Wreturn-type warning in g++. </blockquote><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<br>
Modified:<br>
    llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMBaseInfo.h<br>
<br>
Modified: llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMBaseInfo.h<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMBaseInfo.h?rev=147867&r1=147866&r2=147867&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMBaseInfo.h?rev=147867&r1=147866&r2=147867&view=diff</a><br>

==============================================================================<br>
--- llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMBaseInfo.h (original)<br>
+++ llvm/trunk/lib/Target/ARM/MCTargetDesc/ARMBaseInfo.h Tue Jan 10 13:10:22 2012<br>
@@ -67,6 +67,7 @@<br>
<br>
 inline static const char *ARMCondCodeToString(ARMCC::CondCodes CC) {<br>
   switch (CC) {<br>
+  default: llvm_unreachable("Unknown condition code");<br></blockquote><div><br></div><div>If the enumeration is fully covered, please put the llvm_unreachable after the switch and don't add a default. We're trying to get to a point where we can more effectively use the compiler warnings about non-covering switches.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
   case ARMCC::EQ:  return "eq";<br>
   case ARMCC::NE:  return "ne";<br>
   case ARMCC::HS:  return "hs";<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</blockquote></div><br>