<html>
<head>
<meta http-equiv="Content-Type" content="text/html; charset=us-ascii">
<meta name="Generator" content="Microsoft Exchange Server">
<!-- converted from rtf -->
<style><!-- .EmailQuote { margin-left: 1pt; padding-left: 4pt; border-left: #800000 2px solid; } --></style>
</head>
<body>
<font face="Verdana" size="2"><span style="font-size:10pt;">
<div>Hi,</div>
<div> </div>
<div>I found the following typo in WidenVector case of PromoteIntRes_BIT_CONVERT method, where the original output value type is used rather than the type after transformation. I found it in a code review so I have no specific test for it. The diff is below.</div>
<div> </div>
<div>Thanks, Anat </div>
<div> </div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;">Index: lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp</span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;">===================================================================</span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;">--- lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp (revision 147140)</span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;">+++ lib/CodeGen/SelectionDAG/LegalizeIntegerTypes.cpp (working copy)</span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;">@@ -252,9 +252,9 @@</span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;"> return DAG.getNode(ISD::BITCAST, dl, NOutVT, InOp);</span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;"> }</span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;"> case TargetLowering::TypeWidenVector:</span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;">- if (OutVT.bitsEq(NInVT))</span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;">+ if (NOutVT.bitsEq(NInVT))</span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;"> // The input is widened to the same size. Convert to the widened value.</span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;">- return DAG.getNode(ISD::BITCAST, dl, OutVT, GetWidenedVector(InOp));</span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;">+ return DAG.getNode(ISD::BITCAST, dl, NOutVT, GetWidenedVector(InOp));</span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;"> }</span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;"> return DAG.getNode(ISD::ANY_EXTEND, dl, NOutVT,</span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div>
<div><font face="Calibri" size="2"><span style="font-size:11pt;"> </span></font></div>
</span></font>
<font face="monospace">---------------------------------------------------------------------<br>
Intel Israel (74) Limited<br>
<br>
This e-mail and any attachments may contain confidential material for<br>
the sole use of the intended recipient(s). Any review or distribution<br>
by others is strictly prohibited. If you are not the intended<br>
recipient, please contact the sender and delete all copies.</font></body>
</html>