<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
> Go ahead and commit with those changes.<br>
<br>
Okay, will make those changes and commit. Thanks for the review!<br>
<br>
-Anshu<br>
<br>
<br>
On 12/1/2011 12:49 PM, Jakob Stoklund Olesen wrote:
<blockquote cite="mid:1BE761D9-D718-40F3-99B3-F77713614DBD@2pi.dk"
type="cite"><br>
<div>
<div>On Nov 30, 2011, at 7:54 PM, Anshuman Dasgupta wrote:</div>
<br class="Apple-interchange-newline">
<blockquote type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div bgcolor="#FFFFFF" text="#000000"> <tt>Jakob,<br>
<br>
I'm attaching a patch with the changes that you suggested.<br>
</tt></div>
</blockquote>
<div><br>
</div>
<div>Almost there. Two things:</div>
<div><br>
</div>
<div><a moz-do-not-send="true"
href="http://llvm.org/docs/CodingStandards.html#micro_namespaceindent">http://llvm.org/docs/CodingStandards.html#micro_namespaceindent</a></div>
<div><a moz-do-not-send="true"
href="http://llvm.org/docs/CodingStandards.html#micro_anonns">http://llvm.org/docs/CodingStandards.html#micro_anonns</a></div>
<div><br>
</div>
<div>Don't indent for namespaces, and use individual anonymous
namespaces for each class.</div>
<div><br>
</div>
<div>Go ahead and commit with those changes.</div>
<div><br>
</div>
<div>/jakob</div>
<div><br>
</div>
</div>
</blockquote>
<br>
</body>
</html>