<html>
<head>
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
</head>
<body bgcolor="#FFFFFF" text="#000000">
<tt>Jakob,<br>
<br>
I'm attaching a patch with the changes that you suggested.<br>
<br>
Thanks<br>
-Anshu<br>
<br>
<br>
<br>
On 11/30/2011 5:04 PM, Jakob Stoklund Olesen wrote:</tt>
<blockquote cite="mid:919B981D-2273-4C9B-8C24-EA9C700C6E49@2pi.dk"
type="cite"><tt><br>
</tt>
<div>
<div><tt>On Nov 30, 2011, at 2:44 PM, Anshuman Dasgupta wrote:</tt></div>
<tt><br class="Apple-interchange-newline">
</tt>
<blockquote type="cite">
<meta content="text/html; charset=ISO-8859-1"
http-equiv="Content-Type">
<div bgcolor="#FFFFFF" text="#000000"> <tt><br>
</tt><tt>Jakob,<br>
<br>
I've attached a modified patch with the changes you
suggested. A couple of comments: I will remove the
emission of the second table when I split up the
transition tables for each subtarget in Hexagon since
those two tasks are related. Also, it was possible to
change most of the STL containers (but not all) to LLVM
equivalents. Let me know if it's okay to commit. I will
post the CodeGenerator.html changes as a separate patch.<br>
<br>
</tt></div>
</blockquote>
<div><tt><br>
</tt></div>
<div>
<div><tt>+++ b/utils/TableGen/DFAPacketizerEmitter.h</tt></div>
<div><tt>+</tt></div>
</div>
<div>
<div><tt>+using namespace llvm;</tt></div>
<div><tt>+</tt></div>
<div><tt>+namespace {</tt></div>
<div><tt>+</tt></div>
</div>
<div><tt><br>
</tt></div>
<div><tt>These are both strictly verboten in headers. Also see <a
moz-do-not-send="true"
href="http://llvm.org/docs/CodingStandards.html#micro_anonns">http://llvm.org/docs/CodingStandards.html#micro_anonns</a></tt></div>
<div><tt><br>
</tt></div>
<div><tt>Just move these classes into the .cpp file.</tt></div>
<div><tt><br>
</tt></div>
<div>
<div><tt>+++ b/utils/TableGen/DFAPacketizerEmitter.cpp</tt></div>
<div>
<div><tt>+#include <fstream></tt></div>
</div>
<div><tt><br>
</tt></div>
<div><tt>?</tt></div>
<div><tt><br>
</tt></div>
<div>
<div><tt>+++ b/include/llvm/CodeGen/DFAPacketizer.h</tt></div>
</div>
<div>
<div><tt>+ int CurrentState;</tt></div>
</div>
<div>
<div><tt>+ const int (*DFAStateInputTable)[2];</tt></div>
</div>
<div><tt><br>
</tt></div>
<div><tt>Why int?</tt></div>
<div><tt><br>
</tt></div>
<div><tt>Also, please strip trailing whitespace from your
patch. We have too much of that already.</tt></div>
</div>
<div><tt><br>
</tt></div>
<div><tt>/jakob</tt></div>
<div><tt><br>
</tt></div>
</div>
</blockquote>
<tt><br>
</tt>
</body>
</html>