<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Nov 28, 2011, at 1:38 PM, Anshuman Dasgupta wrote:</div><div><br></div><div><blockquote type="cite"><span class="Apple-style-span" style="font-family: monospace; ">> I would like to review the functionality as well, but that will be a lot easier if you<br>> submit a new patch with documentation first.<br><br>Sure, I've attached documentation on the functionality of the DFA. The document presents an overview of how the DFA is constructed and what it does. I will work on a patch to CodeGenerator.html that will describe the DFA generator but this document should let you review the code's functionality.<br></span></blockquote></div><div><br></div><div>Thanks!</div><div><br></div><blockquote type="cite"><div bgcolor="#FFFFFF" text="#000000">
<div>
<div><tt>> +class State {</tt></div>
</div>
<div>
<div><tt>> +struct Transition {</tt></div>
</div>
<div>
<div><tt>> +class DFA {</tt></div>
</div>
<div><tt>><br>
</tt></div>
<div><tt>> Even for TableGen, these names are too generic to go
in the llvm namespace.</tt></div>
<div><tt><br>
Okay, I'll think of more specific names probably along the lines
of prepending VLIWPacketizer to these names.<br></tt></div></div></blockquote><div><br></div><div>Even better, stick them in an anonymous namespace in DFAPacketizerEmitter.cpp, if possible.</div></div><br><div>/jakob</div><div><br></div></body></html>