<br><br><div class="gmail_quote">On Thu, Nov 17, 2011 at 3:36 PM, NAKAMURA Takumi <span dir="ltr"><<a href="mailto:geek4civic@gmail.com">geek4civic@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Kostya,<br>
<div class="im"><br>
> --- llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp (original)<br>
> +++ llvm/trunk/lib/Transforms/Instrumentation/AddressSanitizer.cpp Thu Nov 17 17:14:59 2011<br>
> @@ -448,8 +448,11 @@<br>
><br>
>     if (!Ty->isSized()) continue;<br>
>     if (!G->hasInitializer()) continue;<br>
> -    if (GlobalVariable::mayBeOverridden(G->getLinkage()) ||<br>
> -        G->getLinkage() == GlobalVariable::AppendingLinkage)<br>
> +    // Touch only those globals that will not be defined in other modules.<br>
> +    // Don't handle ODR type linkages since other modules may be built w/o asan.<br>
> +    if (G->getLinkage() != GlobalVariable::GlobalVariable::ExternalLinkage &&<br>
> +        G->getLinkage() != GlobalVariable::GlobalVariable::PrivateLinkage &&<br>
> +        G->getLinkage() != GlobalVariable::GlobalVariable::InternalLinkage)<br>
>       continue;<br>
>     // For now, just ignore this Alloca if the alignment is large.<br>
>     if (G->getAlignment() > RedzoneSize) continue;<br>
<br>
</div>What is "GlobalVariable::GlobalVariable::"?<br></blockquote><div>Ouch! Thanks for the post review! Will fix shortly. </div><div><br></div><div>--kcc  </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">

FYI, MSVC does not accept them.<br>
<span class="HOEnZb"><font color="#888888"><br>
...Takumi<br>
</font></span></blockquote></div><br>