<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Nov 14, 2011, at 9:55 PM, Craig Topper wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Optima; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="font-family: monospace; ">--- llvm/trunk/lib/Target/X86/X86TargetMachine.cpp (original)<br>+++ llvm/trunk/lib/Target/X86/X86TargetMachine.cpp Mon Nov 14 23:55:35 2011<br>@@ -140,10 +140,7 @@<br> PM.add(createExecutionDependencyFixPass(&X86::VR128RegClass));<br> ShouldPrint = true;<br> }<br>- if (Subtarget.hasAVX2()) {<br>- // FIXME this should be turned on for just AVX, but the pass doesn't check<br>- // that instructions are valid before replacing them and there are AVX2<br>- // integer instructions in the table.<br>+ if (Subtarget.hasAVX()) {<br> PM.add(createExecutionDependencyFixPass(&X86::VR256RegClass));<br> ShouldPrint = true;<br> }<br></span></span></blockquote></div><br><div>Perhaps you could change this back to the simpler (Subtarget.hasSSE2() || Subtarget.hasAVX())?</div><div><br></div><div>It doesn't make a difference if you pass the VR128 or VR256 register class. The pass collapses aliases anyway.</div><div><br></div><div>/jakob</div><div><br></div></body></html>