<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">Whoops,<div><br></div><div>It works just fine </div><div><br></div><div>Joe</div><div><br><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; font-variant: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><font class="Apple-style-span" color="#a9a9a9" face="'Times New Roman'" size="2">Joe Abbey<br>Software Architect<br>Arxan Technologies, Inc.<br>1305 Cumberland Ave, Ste 215<br>West Lafayette, IN 47906<br><a href="mailto:jabbey@arxan.com">jabbey@arxan.com</a><br>www.arxan.com</font><br><br></div></span></span></div><div><div>On Nov 5, 2011, at 11:52 AM, Joe Abbey wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; ">pr11300.ll still fails on PPC with this patch.<div><br></div><div>Please apply </div><div><br></div><div><div>Index: lib/DebugInfo/DWARFDebugInfoEntry.cpp</div><div>===================================================================</div><div>--- lib/DebugInfo/DWARFDebugInfoEntry.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>(revision 143812)</div><div>+++ lib/DebugInfo/DWARFDebugInfoEntry.cpp<span class="Apple-tab-span" style="white-space:pre"> </span>(working copy)</div><div>@@ -26,9 +26,9 @@</div><div> uint32_t offset = Offset;</div><div> </div><div> if (debug_info_data.isValidOffset(offset)) {</div><div>+ OS << format("\n0x%8.8x: ", offset);</div><div> uint32_t abbrCode = debug_info_data.getULEB128(&offset);</div><div>-</div><div>- OS << format("\n0x%8.8x: ", Offset);</div><div>+ </div><div> if (abbrCode) {</div><div> if (AbbrevDecl) {</div><div> const char *tagString = TagString(getTag());</div><div><br></div><div>Cheers,</div><div><br></div><div apple-content-edited="true">
<span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><span class="Apple-style-span" style="border-collapse: separate; font-variant: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; "><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><font class="Apple-style-span" color="#a9a9a9" face="'Times New Roman'" size="2">Joe Abbey<br>Software Architect<br>Arxan Technologies, Inc.<br>1305 Cumberland Ave, Ste 215<br>West Lafayette, IN 47906<br><a href="mailto:jabbey@arxan.com">jabbey@arxan.com</a><br><a href="http://www.arxan.com">www.arxan.com</a></font><br><br></div></span></span>
</div>
<br><div><div>On Nov 5, 2011, at 11:35 AM, Benjamin Kramer wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Author: d0k<br>Date: Sat Nov 5 10:35:00 2011<br>New Revision: 143812<br><br>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=143812&view=rev">http://llvm.org/viewvc/llvm-project?rev=143812&view=rev</a><br>Log:<br>Reduce the offsets in DwarfDebugInfoEntry to 32 bit, they're printed with %x and<br>that breaks on big-endian machines.<br><br>I have to clean up the 32/64 bit confusion in libDebugInfo some day.<br><br>Modified:<br> llvm/trunk/lib/DebugInfo/DWARFDebugInfoEntry.cpp<br> llvm/trunk/lib/DebugInfo/DWARFDebugInfoEntry.h<br><br>Modified: llvm/trunk/lib/DebugInfo/DWARFDebugInfoEntry.cpp<br>URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFDebugInfoEntry.cpp?rev=143812&r1=143811&r2=143812&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFDebugInfoEntry.cpp?rev=143812&r1=143811&r2=143812&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/DebugInfo/DWARFDebugInfoEntry.cpp (original)<br>+++ llvm/trunk/lib/DebugInfo/DWARFDebugInfoEntry.cpp Sat Nov 5 10:35:00 2011<br>@@ -26,7 +26,7 @@<br> uint32_t offset = Offset;<br><br> if (debug_info_data.isValidOffset(offset)) {<br>- uint64_t abbrCode = debug_info_data.getULEB128(&offset);<br>+ uint32_t abbrCode = debug_info_data.getULEB128(&offset);<br><br> OS << format("\n0x%8.8x: ", Offset);<br> if (abbrCode) {<br><br>Modified: llvm/trunk/lib/DebugInfo/DWARFDebugInfoEntry.h<br>URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFDebugInfoEntry.h?rev=143812&r1=143811&r2=143812&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/DebugInfo/DWARFDebugInfoEntry.h?rev=143812&r1=143811&r2=143812&view=diff</a><br>==============================================================================<br>--- llvm/trunk/lib/DebugInfo/DWARFDebugInfoEntry.h (original)<br>+++ llvm/trunk/lib/DebugInfo/DWARFDebugInfoEntry.h Sat Nov 5 10:35:00 2011<br>@@ -23,7 +23,7 @@<br> /// DWARFDebugInfoEntryMinimal - A DIE with only the minimum required data.<br> class DWARFDebugInfoEntryMinimal {<br> /// Offset within the .debug_info of the start of this entry.<br>- uint64_t Offset;<br>+ uint32_t Offset;<br><br> /// How many to subtract from "this" to get the parent.<br> /// If zero this die has no parent.<br>@@ -52,7 +52,7 @@<br><br> uint32_t getTag() const { return AbbrevDecl ? AbbrevDecl->getTag() : 0; }<br> bool isNULL() const { return AbbrevDecl == 0; }<br>- uint64_t getOffset() const { return Offset; }<br>+ uint32_t getOffset() const { return Offset; }<br> uint32_t getNumAttributes() const {<br> return !isNULL() ? AbbrevDecl->getNumAttributes() : 0;<br> }<br><br><br>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br></div></blockquote></div><br></div></div>_______________________________________________<br>llvm-commits mailing list<br><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits<br></blockquote></div><br></div></body></html>