<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Nov 1, 2011, at 5:59 PM, Nick Lewycky wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On 21 October 2011 14:11, Nick Lewycky <span dir="ltr"><<a href="mailto:nlewycky@google.com" target="_blank">nlewycky@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div class="gmail_quote"><div>On 18 October 2011 15:53, Nick Lewycky <span dir="ltr"><<a href="mailto:nlewycky@google.com" target="_blank">nlewycky@google.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
In DWARF, the file table contains indices back into the directory table. As an optimization, directory entry zero is assumed to refer to the value in DW_at_comp_dir. Don't emit two copies of that string!<div><br></div>
<div>Please review!</div></blockquote><div><br></div></div><div>Ping! <a href="http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20111017/130273.html" target="_blank">http://lists.cs.uiuc.edu/pipermail/llvm-commits/Week-of-Mon-20111017/130273.html</a></div>
<div><br></div><div>I know Eric started looking at this and was hoping it's be possible to do in a different, cleaner way. I'd be happy to change how it works if anyone has a proposal. As it stands right now, we assume that a blank directory entry means "use directory entry zero" which is what GNU as and llvm-mc have always done. This patch causes us to emit ".file index filename" with no directory part when the directory is equal to the comp_dir.</div>
</div></blockquote><div><br></div><div>Updated patch. Renamed "DirIndexZero" to "CompilationDir" and added another test. Please review!</div></div></blockquote><br></div><div>I'm still not wild about the cleaner way, but I don't have a proposal either. Can you put a comment that we should probably find a different way to do this?</div><div><br></div><div>Thanks!</div><div><br></div><div>-eric</div><br></body></html>