<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Oct 17, 2011, at 10:29 AM, Owen Anderson wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Nadav,<br><br><br>On Oct 16, 2011, at 1:31 PM, Nadav Rotem wrote:<br><br><blockquote type="cite">Author: nadav<br></blockquote><blockquote type="cite">Date: Sun Oct 16 15:31:33 2011<br></blockquote><blockquote type="cite">New Revision: 142152<br></blockquote><br>…<br><br><blockquote type="cite">Modified: llvm/trunk/test/CodeGen/ARM/vrev.ll<br></blockquote><blockquote type="cite">URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/vrev.ll?rev=142152&r1=142151&r2=142152&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/test/CodeGen/ARM/vrev.ll?rev=142152&r1=142151&r2=142152&view=diff</a><br></blockquote><blockquote type="cite">==============================================================================<br></blockquote><blockquote type="cite">--- llvm/trunk/test/CodeGen/ARM/vrev.ll (original)<br></blockquote><blockquote type="cite">+++ llvm/trunk/test/CodeGen/ARM/vrev.ll Sun Oct 16 15:31:33 2011<br></blockquote><blockquote type="cite">@@ -150,9 +150,6 @@<br></blockquote><blockquote type="cite"><br></blockquote><blockquote type="cite">; vrev <4 x i16> should use VREV32 and not VREV64<br></blockquote><blockquote type="cite">define void @test_vrev64(<4 x i16>* nocapture %source, <2 x i16>* nocapture %dst) nounwind ssp {<br></blockquote><blockquote type="cite">-; CHECK: test_vrev64:<br></blockquote><blockquote type="cite">-; CHECK: vext.16<br></blockquote><blockquote type="cite">-; CHECK: vrev32.16<br></blockquote><blockquote type="cite">entry:<br></blockquote><blockquote type="cite"> %0 = bitcast <4 x i16>* %source to <8 x i16>*<br></blockquote><blockquote type="cite"> %tmp2 = load <8 x i16>* %0, align 4<br></blockquote><br>You've removed all the CHECK lines from this test, essentially disabling it. Please make sure it still works and add back correct CHECK lines.<br></div></blockquote></div><br><div>To follow up on my own post, it does <i>not</i> still work. The new generated code is MUCH worse than what is being checked for, involve extra stores rather than a shuffle instruction. Please fix this or re-disable this patch until it can be fixed.</div><div><br></div><div>--Owen</div></body></html>