<div class="gmail_quote">On Tue, Sep 27, 2011 at 4:01 PM, Eli Friedman <span dir="ltr"><<a href="mailto:eli.friedman@gmail.com">eli.friedman@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div class="im">On Tue, Sep 27, 2011 at 12:25 PM, Justin Holewinski<br>
<<a href="mailto:justin.holewinski@gmail.com">justin.holewinski@gmail.com</a>> wrote:<br>
> Author: jholewinski<br>
> Date: Tue Sep 27 14:25:49 2011<br>
> New Revision: 140624<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=140624&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=140624&view=rev</a><br>
> Log:<br>
> PTX: Fix case where printed alignment could be 0<br>
><br>
> Modified:<br>
>    llvm/trunk/lib/Target/PTX/PTXAsmPrinter.cpp<br>
><br>
> Modified: llvm/trunk/lib/Target/PTX/PTXAsmPrinter.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PTX/PTXAsmPrinter.cpp?rev=140624&r1=140623&r2=140624&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PTX/PTXAsmPrinter.cpp?rev=140624&r1=140623&r2=140624&view=diff</a><br>

> ==============================================================================<br>
> --- llvm/trunk/lib/Target/PTX/PTXAsmPrinter.cpp (original)<br>
> +++ llvm/trunk/lib/Target/PTX/PTXAsmPrinter.cpp Tue Sep 27 14:25:49 2011<br>
> @@ -480,7 +480,7 @@<br>
>   unsigned alignment = gv->getAlignment();<br>
>   if (alignment != 0) {<br>
>     decl += ".align ";<br>
> -    decl += utostr(Log2_32(gv->getAlignment()));<br>
> +    decl += utostr(std::max(1U, Log2_32(gv->getAlignment())));<br>
>     decl += " ";<br>
>   }<br>
<br>
</div>This looks wrong: you're making sure the alignment is at least 2 bytes?!<br></blockquote><div><br></div><div>No, this is making sure it is at least 1 byte. There were some cases where the Log2 function was returning 0.</div>
<div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<font color="#888888"><br>
-Eli<br>
</font></blockquote></div><br><br clear="all"><div><br></div>-- <br><br><div>Thanks,</div><div><br></div><div>Justin Holewinski</div><br>