<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Aug 31, 2011, at 5:06 AM, arrowdodger wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">
On Sat, Aug 6, 2011 at 2:21 PM, arrowdodger <span dir="ltr"><<a href="mailto:6yearold@gmail.com" target="_blank">6yearold@gmail.com</a>></span> wrote:<br><div class="gmail_quote"><div><div><div class="gmail_quote">
<div><div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Hi, there is LLVM_MULTITHREADED define which is actually indicates presence of atomic builtins in the host system. Such name may confuse developers in future and already confused someone at lib/Support/Threading.cpp - he used this define to check whether LLVM is built with threading support. This mistake is currently blocking single-threaded build on Unix.<br>
<br>This patch do following things:<br>1. Rename LLVM_MULTITHREADED to LLVM_HAVE_ATOMICS in CMake checking code and <a href="http://configure.ac/" target="_blank">configure.ac</a>, fix description of this option.<br>2. Replaces all uses of old define with new one.<br>
3. Fix lib/Support/Threading.cpp file by using ENABLE_THREADS define instead of LLVM_MULTITHREADED.<br>
</blockquote></div></div></div></div></div></div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex"><div><div><div class="gmail_quote"><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
<div><div>
</div></div></blockquote></div></div></div></blockquote></div><br>Ping.<br>
<span><llvm.atomics.define.diff></span>_______________________________________________<br></blockquote><br></div><div>Sorry for the delay. In general the patch is fine, could you change these couple of things?</div><div><br></div><div>LLVM_HAVE_ATOMICS -> LLVM_HAS_ATOMICS</div><div><br></div><div>and</div><div><br></div><div><div>-#if LLVM_MULTITHREADED==0</div><div>+#if LLVM_HAVE_ATOMICS==0 || !defined(LLVM_HAVE_ATOMICS)</div><div><br></div><div>to just #if LLVM_HAS_ATOMICS</div><div><br></div><div>this latter is ok because we define it either way so there's always a value at least as far as the autoconf bits are concerned. If this isn't true for the cmake bits let me know.</div><div><br></div><div>-eric</div></div><br></body></html>