<br><br><div class="gmail_quote">On 6 September 2011 09:48, Eli Friedman <span dir="ltr"><<a href="mailto:eli.friedman@gmail.com">eli.friedman@gmail.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">

<div class="im">On Mon, Sep 5, 2011 at 11:56 PM, Nick Lewycky <<a href="mailto:nicholas@mxc.ca">nicholas@mxc.ca</a>> wrote:<br>
> Author: nicholas<br>
> Date: Tue Sep  6 01:56:00 2011<br>
> New Revision: 139138<br>
><br>
> URL: <a href="http://llvm.org/viewvc/llvm-project?rev=139138&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=139138&view=rev</a><br>
> Log:<br>
> Apparently we compile the code, not the comments. Thanks Eli!<br>
<br>
</div>Sure. :)<br>
<br>
BTW, please commit a test for this...<br></blockquote><div><br></div><div>Actually, Transforms/IndVarSimplify/test_compute.ll's @quadratic_setlt will suffice.</div><div><br></div><div>Nick</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">


<span class="HOEnZb"><font color="#888888"><br>
-Eli<br>
</font></span><div class="HOEnZb"><div></div><div class="h5"><br>
> Modified:<br>
>    llvm/trunk/lib/Analysis/ScalarEvolution.cpp<br>
><br>
> Modified: llvm/trunk/lib/Analysis/ScalarEvolution.cpp<br>
> URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ScalarEvolution.cpp?rev=139138&r1=139137&r2=139138&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Analysis/ScalarEvolution.cpp?rev=139138&r1=139137&r2=139138&view=diff</a><br>


> ==============================================================================<br>
> --- llvm/trunk/lib/Analysis/ScalarEvolution.cpp (original)<br>
> +++ llvm/trunk/lib/Analysis/ScalarEvolution.cpp Tue Sep  6 01:56:00 2011<br>
> @@ -1998,8 +1998,7 @@<br>
>               const SCEV *NewStart = getMulExpr(A, C);<br>
>               const SCEV *BD = getMulExpr(B, D);<br>
>               const SCEV *NewStep = getAddExpr(getMulExpr(A, D),<br>
> -                                               getMulExpr(B, C),<br>
> -                                               getNegativeSCEV(BD));<br>
> +                                               getMulExpr(B, C), BD);<br>
>               const SCEV *NewSecondOrderStep =<br>
>                   getMulExpr(BD, getConstant(BD->getType(), 2));<br>
><br>
><br>
><br>
> _______________________________________________<br>
> llvm-commits mailing list<br>
> <a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
> <a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
><br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
</div></div></blockquote></div><br>