<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Aug 15, 2011, at 11:40 AM, Eric Christopher wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><base href="x-msg://18520/"><div style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Aug 15, 2011, at 7:23 AM, James Molloy wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><div lang="EN-GB" link="blue" vlink="purple"><div class="WordSection1" style="page: WordSection1; "><div style="margin-top: 0cm; margin-right: 0cm; margin-left: 0cm; margin-bottom: 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; ">Hi,<o:p></o:p></div><div style="margin-top: 0cm; margin-right: 0cm; margin-left: 0cm; margin-bottom: 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; "><o:p> </o:p></div><div style="margin-top: 0cm; margin-right: 0cm; margin-left: 0cm; margin-bottom: 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; ">The attached patch fixes decoding of LDRSB and LDRSH in 16-bit Thumb mode. Testcase added.<o:p></o:p></div><div style="margin-top: 0cm; margin-right: 0cm; margin-left: 0cm; margin-bottom: 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; "><o:p> </o:p></div><div style="margin-top: 0cm; margin-right: 0cm; margin-left: 0cm; margin-bottom: 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; ">Cheers,<o:p></o:p></div><div style="margin-top: 0cm; margin-right: 0cm; margin-left: 0cm; margin-bottom: 0.0001pt; font-size: 11pt; font-family: Calibri, sans-serif; "><o:p> </o:p></div></div></div></span></blockquote><br></div><div><div> let EncoderMethod = "getThumbAddrModeRegRegOpValue";</div><div> let PrintMethod = "printThumbAddrModeRROperand";</div><div>+ let DecoderMethod = "DecodeThumbAddrModeRR";</div><div> let MIOperandInfo = (ops tGPR:$base, tGPR:$offsreg);</div><div> }</div><div><br></div><div>This appears to be the actual fix and the rest is some random renaming? Also could you add a test for ldrsh as well?</div></div></div></blockquote><br></div><div>No, the renaming is necessary because the auto-generated decoder emitter can only auto-generate operand parsers when the names match up.</div><div><br></div><div>Otherwise, this looks fine, and I'll apply it, but please do submit a testcase when you can.</div><div><br></div><div>--Owen</div><br></body></html>