Hi Dani,<div><br></div><div><br><div class="gmail_quote">On Fri, Aug 5, 2011 at 11:58 AM, Danil Malyshev <span dir="ltr"><<a href="mailto:dmalyshev@accesssoftek.com">dmalyshev@accesssoftek.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div lang="RU" link="blue" vlink="blue">
<div>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy">Hello,<u></u><u></u></span></font></p>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy"><u></u> <u></u></span></font></p>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy">> 1. Which
architecture is to be supported first?<u></u><u></u></span></font></p>
<p class="MsoNormal"><font size="3" color="black" face="Times New Roman"><span lang="EN-US" style="font-size:12.0pt;color:black"><u></u> <u></u></span></font></p>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy">Currently I'm working on
the armv7 support.<u></u><u></u></span></font></p>
<p class="MsoNormal"><font size="3" color="black" face="Times New Roman"><span lang="EN-US" style="font-size:12.0pt;color:black"><u></u></span></font></p></div></div></blockquote><div><br></div><div>Great!</div><div><br>
</div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;"><div lang="RU" link="blue" vlink="blue"><div><p class="MsoNormal"><font size="3" color="black" face="Times New Roman"><span lang="EN-US" style="font-size:12.0pt;color:black"> <u></u></span></font></p>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy">> 2. How will you
split off architecture specific details, such as ..</span></font><font color="black"><span lang="EN-US" style="color:black"><u></u><u></u></span></font></p>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy">> 3. Relocations
during JIT?<u></u><u></u></span></font></p>
<p class="MsoNormal"><font size="3" color="black" face="Times New Roman"><span lang="EN-US" style="font-size:12.0pt;color:black"><u></u> <u></u></span></font></p>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy">This class provides an
access to symbol and relocation data, which is the same for all architectures.</span></font><font color="navy"><span lang="EN-US" style="color:navy"><u></u><u></u></span></font></p>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy">Architecture specific
details will be handled by the dynamic linker.</span></font><font color="navy"><span lang="EN-US" style="color:navy"><u></u><u></u></span></font></p><div class="im">
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy"><u></u> <u></u></span></font></p>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy">> Is it intended to
ever support 64 bit elf files directly? If so, you'll have to do something
about the 32bit offset helpers below (for starters) and/or the class name (for
clarity) If not, then should this class be called ELF32Object?</span></font><font color="black"><span lang="EN-US" style="color:black"><u></u><u></u></span></font></p>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy"><u></u> <u></u></span></font></p>
</div><p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy">I have changed the
proposed class to be a template with 2 instances: ELF32Object and ELF64Object.</span></font><font color="navy"><span lang="EN-US" style="color:navy"><u></u><u></u></span></font></p>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy">Please find the patch
attached.</span></font><font color="navy"><span lang="EN-US" style="color:navy"><u></u><u></u></span></font></p>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy"><u></u> </span></font></p></div></div></blockquote><div><br></div><div>Overall, it looks pretty good. </div>
<div><br></div><div>I'd feel better if there was at least some unification between ELFObject and ELFObjectFile -- if only for the representation of the ELF blob's layout.</div><div>I don't see why we need to have a total bifurcation here. Whether its a file or an in-memory object, the representation is the same, right? The latter should have the file-io specific routines that the in-memory does not need....</div>
<div><br></div><div>Some specific nits: </div><div><br></div><div>The getOffset() routine is misnamed - perhaps it should be getData()? (consolation: it agrees with the existing MachOObject.h :-)</div><div><br></div><div>
Also, it still uses a 32bit offset field even in the 64 bit case - can you please fix this somehow? (Perhaps look at ELFObjectFile.cpp for inspiration?)</div><div><br></div><div>Thanks!</div><div><br></div><div> </div><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<div lang="RU" link="blue" vlink="blue"><div><p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy"><u></u></span></font></p>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy"><u></u> <u></u></span></font></p>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy"><u></u> <u></u></span></font></p>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy">Regards,<u></u><u></u></span></font></p>
<p class="MsoNormal"><font size="2" color="navy" face="Arial"><span lang="EN-US" style="font-size:10.0pt;font-family:Arial;color:navy">Danil<u></u><u></u></span></font></p>
</div>
</div>
</blockquote></div><br></div>