<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jul 18, 2011, at 1:31 PM, Akira Hatanaka wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite">Do you mean I should use vector or array instead? Or should I change the name "Tmp"? I understand "Tmp" is not very descriptive, but these registers are used as temporaries to store intermediate results.<br></blockquote><div><br></div><div>Don't use an array. I meant that you should use more descriptive names.</div><div><br></div><div>I understand that these are in fact temporary variables, but Tmp1-Tmp13 is just too many. It must be possible to find better names.</div><div><br></div><div>It is also confusing that Tmp5 is now missing.</div><div><br></div><div>I am sorry to pin this on you. Maybe we should make Bruno fix it, if it is difficult? Or Sasa?</div><div><br></div><div>Thanks,</div><div>/jakob</div><div><br></div><div><br></div><div><br></div><blockquote type="cite">Thank you.<br><br><div class="gmail_quote">On Mon, Jul 18, 2011 at 1:22 PM, Jakob Stoklund Olesen <span dir="ltr"><<a href="mailto:stoklund@2pi.dk">stoklund@2pi.dk</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin-top: 0pt; margin-right: 0pt; margin-bottom: 0pt; margin-left: 0.8ex; border-left-width: 1px; border-left-style: solid; border-left-color: rgb(204, 204, 204); padding-left: 1ex; position: static; z-index: auto; ">
<br>
On Jul 18, 2011, at 12:58 PM, Akira Hatanaka wrote:<br>
<br>
> @@ -819,7 +819,6 @@<br>
> unsigned Tmp2 = RegInfo.createVirtualRegister(RC);<br>
> unsigned Tmp3 = RegInfo.createVirtualRegister(RC);<br>
> unsigned Tmp4 = RegInfo.createVirtualRegister(RC);<br>
> - unsigned Tmp5 = RegInfo.createVirtualRegister(RC);<br>
> unsigned Tmp6 = RegInfo.createVirtualRegister(RC);<br>
> unsigned Tmp7 = RegInfo.createVirtualRegister(RC);<br>
> unsigned Tmp8 = RegInfo.createVirtualRegister(RC);<br>
<br>
Interesting naming scheme. Please fix that. (I know you didn't do it.)<br>
<br>
<a href="http://llvm.org/docs/CodingStandards.html#ll_naming" target="_blank">http://llvm.org/docs/CodingStandards.html#ll_naming</a><br>
<br>
Thanks,<br>
<font color="#888888">/jakob<br>
<br>
</font></blockquote></div><br>
</blockquote></div><br></body></html>