<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On Jun 20, 2011, at 12:59 PM, Jakob Stoklund Olesen wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div><br>On Jun 20, 2011, at 8:56 AM, Justin Holewinski wrote:<br><br><blockquote type="cite">+ int OpCode;<br></blockquote><blockquote type="cite">+<br></blockquote><blockquote type="cite">+ // Select the appropriate opcode based on the register class<br></blockquote><blockquote type="cite">+ if (RC == PTX::RegI16RegisterClass) {<br></blockquote><blockquote type="cite">+ OpCode = PTX::STACKSTOREI16;<br></blockquote><blockquote type="cite">+ }<br></blockquote><blockquote type="cite">+ else if (RC == PTX::RegI32RegisterClass) {<br></blockquote><blockquote type="cite">+ OpCode = PTX::STACKSTOREI32;<br></blockquote><blockquote type="cite">+ }<br></blockquote><blockquote type="cite">+ else if (RC == PTX::RegI64RegisterClass) {<br></blockquote><blockquote type="cite">+ OpCode = PTX::STACKSTOREI32;<br></blockquote><blockquote type="cite">+ }<br></blockquote><blockquote type="cite">+ else if (RC == PTX::RegF32RegisterClass) {<br></blockquote><blockquote type="cite">+ OpCode = PTX::STACKSTOREF32;<br></blockquote><blockquote type="cite">+ }<br></blockquote><blockquote type="cite">+ else if (RC == PTX::RegF64RegisterClass) {<br></blockquote><blockquote type="cite">+ OpCode = PTX::STACKSTOREF64;<br></blockquote><blockquote type="cite">+ }<br></blockquote><br>Please add an assertion for the unknown register class case.<br><br>Also, format your else-ifs like so:<br><br>} else if (..) {<br></div></blockquote><div><br></div><div>Fixed in r133447.</div><br><blockquote type="cite"><div><br>/jakob<br><br></div></blockquote></div><br><div>
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: 'Lucida Grande'; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">Thanks,<br><br>Justin Holewinski</span>
</div>
<br></body></html>