<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Jun 17, 2011, at 3:31 AM, 陳韋任 wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div>Hi, Justin<br><br> I add ".address_size" directive support and a test case.<br><br> Is it O.K. to be committed? Thanks!<br></div></blockquote><div><br></div><div>Perhaps my understanding of the .address_size directive is incomplete, but as far as I know it is just used as a flag for ptxas to make sure all PTX modules in a program assume the same pointer size. That said, what is the purpose of allowing LLVM to generate 32-bit PTX code but assume 64-bit addresses, and vice versa? Why not tie the directive directly to the existing 32/64-bit flag instead of allowing user intervention?</div><div><br></div><div>Also, .address_size is only supported on PTX 2.3+. Please amend the patch to emit this directive only if the target PTX version is >= 2.3.</div><br><blockquote type="cite"><div><br>Regards,<br>chenwj<br><br>-- <br>Wei-Ren Chen (陳韋任)<br>Computer Systems Lab, Institute of Information Science,<br>Academia Sinica, Taiwan (R.O.C.)<br>Tel:886-2-2788-3799 #1667<br><span><patch-llvm-133249.txt></span></div></blockquote></div><br><div>
<span class="Apple-style-span" style="border-collapse: separate; color: rgb(0, 0, 0); font-family: 'Lucida Grande'; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-align: -webkit-auto; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; ">Thanks,<br><br>Justin Holewinski</span>
</div>
<br></body></html>