<html><body bgcolor="#FFFFFF"><div><br><br><br></div><div><br>On Jun 9, 2011, at 6:17 PM, Eli Friedman <<a href="mailto:eli.friedman@gmail.com">eli.friedman@gmail.com</a>> wrote:<br><br></div><div></div><blockquote type="cite"><div><span>On Thu, Jun 9, 2011 at 5:53 PM, Chad Rosier <<a href="mailto:mcrosier@apple.com">mcrosier@apple.com</a>> wrote:</span><br><blockquote type="cite"><span>Author: mcrosier</span><br></blockquote><blockquote type="cite"><span>Date: Thu Jun 9 19:53:15 2011</span><br></blockquote><blockquote type="cite"><span>New Revision: 132825</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>URL: <a href="http://llvm.org/viewvc/llvm-project?rev=132825&view=rev"><a href="http://llvm.org/viewvc/llvm-project?rev=132825&view=rev">http://llvm.org/viewvc/llvm-project?rev=132825&view=rev</a></a></span><br></blockquote><blockquote type="cite"><span>Log:</span><br></blockquote><blockquote type="cite"><span>Ensure that EmitGlobalVariable is correctly differentiating between declarations</span><br></blockquote><blockquote type="cite"><span>and definitions when emitting global variables. This was causing global</span><br></blockquote><blockquote type="cite"><span>declarations to be emitted as if they were definitions.</span><br></blockquote><blockquote type="cite"><span>Fixes <<a href="rdar://problem/9429892">rdar://problem/9429892</a>>.</span><br></blockquote><span></span><br><span>Testcase?</span><font class="Apple-style-span" color="#000000"><font class="Apple-style-span" color="#0023A3"><br></font></font></div></blockquote><div><br></div>Sorry about that. Working on this now.<br><br><blockquote type="cite"><div><span>-Eli</span><br><span></span><br><blockquote type="cite"><span>Modified:</span><br></blockquote><blockquote type="cite"><span> llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>Modified: llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp</span><br></blockquote><blockquote type="cite"><span>URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=132825&r1=132824&r2=132825&view=diff"><a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=132825&r1=132824&r2=132825&view=diff">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp?rev=132825&r1=132824&r2=132825&view=diff</a></a></span><br></blockquote><blockquote type="cite"><span>==============================================================================</span><br></blockquote><blockquote type="cite"><span>--- llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp (original)</span><br></blockquote><blockquote type="cite"><span>+++ llvm/trunk/lib/CodeGen/AsmPrinter/AsmPrinter.cpp Thu Jun 9 19:53:15 2011</span><br></blockquote><blockquote type="cite"><span>@@ -269,7 +269,7 @@</span><br></blockquote><blockquote type="cite"><span> }</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span> MCSymbol *GVSym = Mang->getSymbol(GV);</span><br></blockquote><blockquote type="cite"><span>- EmitVisibility(GVSym, GV->getVisibility());</span><br></blockquote><blockquote type="cite"><span>+ EmitVisibility(GVSym, GV->getVisibility(), !GV->isDeclaration());</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span> if (!GV->hasInitializer()) // External globals require no extra code.</span><br></blockquote><blockquote type="cite"><span> return;</span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span></span><br></blockquote><blockquote type="cite"><span>_______________________________________________</span><br></blockquote><blockquote type="cite"><span>llvm-commits mailing list</span><br></blockquote><blockquote type="cite"><span><a href="mailto:llvm-commits@cs.uiuc.edu">llvm-commits@cs.uiuc.edu</a></span><br></blockquote><blockquote type="cite"><span><a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a></span><br></blockquote><blockquote type="cite"><span></span><br></blockquote></div></blockquote></body></html>