<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><br><div><div>On May 21, 2011, at 9:41 PM, Nick Lewycky wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><span class="Apple-style-span" style="border-collapse: separate; font-family: Helvetica; font-style: normal; font-variant: normal; font-weight: normal; letter-spacing: normal; line-height: normal; orphans: 2; text-indent: 0px; text-transform: none; white-space: normal; widows: 2; word-spacing: 0px; -webkit-border-horizontal-spacing: 0px; -webkit-border-vertical-spacing: 0px; -webkit-text-decorations-in-effect: none; -webkit-text-size-adjust: auto; -webkit-text-stroke-width: 0px; font-size: medium; "><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; "><div style="word-wrap: break-word; "><div>In FindLifetimeMarkers, why push entries into a vector then iterate over the vector? You can just pull your "for each use" inner loop out to its own predicate function and eliminate the smallvector.</div></div></blockquote><div><br></div><div>Good catch!</div><div><br></div><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; "><div style="word-wrap: break-word; "><div> Also, there is no need for both the start and end intrinsic: if you find either, you can assume that there is no need to add one for an alloca. Here's an example where you'd have a start but no end (assuming a frontend was generating them):</div><div><br></div><div>void foo() { </div><div> int x;</div><div> bar(&x);</div><div> abort();</div><div>}</div><div><br></div><div>As such, instead of "finding" them both, please rename the predicate to "hasLifetimeMarkers()".</div></div></blockquote><div><br></div><div>I'm convinced. Updated patch attached!</div></span><br class="Apple-interchange-newline"></blockquote></div><br><div>Looks good to me, with the addition of a comment before:</div><div><br></div><div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">+ if (hasLifetimeMarkers(AI))</div><div style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0px; font: normal normal normal 11px/normal Menlo; ">+ continue;</div></div><div><br></div><div>explaining what is going on. Thanks!</div><div><br></div><div>-Chris</div></body></html>