<div class="gmail_quote">On Tue, May 10, 2011 at 10:52 AM, Dan Bailey <span dir="ltr"><<a href="mailto:drb@dneg.com">drb@dneg.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Justin,<br>
<br>
Sorry for not spotting this earlier, bitwise.ll seems to have been added, but I think these three tests were missed off their various commit - cvt.ll, fneg.ll, selp.ll<br>
<br>
I've attached them again here as a patch, could we get them added in please?<br></blockquote><div><br></div><div>Whoops, looks like I forgot to add them those files to the commits. Fixed in r131128.</div><div> </div>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
<br>
Thanks,<br><font color="#888888">
Dan</font><div><div></div><div class="h5"><br>
<br>
Justin Holewinski wrote:<br>
<blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex">
Author: jholewinski<br>
Date: Wed Apr 27 19:19:54 2011<br>
New Revision: 130356<br>
<br>
URL: <a href="http://llvm.org/viewvc/llvm-project?rev=130356&view=rev" target="_blank">http://llvm.org/viewvc/llvm-project?rev=130356&view=rev</a><br>
Log:<br>
PTX: mov fix and rounding correction for cvt<br>
<br>
- fix typo in MOV<br>
- correct fp rounding on CVT<br>
- new cvt.ll test<br>
<br>
Patch by Dan Bailey<br>
<br>
Modified:<br>
llvm/trunk/lib/Target/PTX/PTXInstrInfo.td<br>
<br>
Modified: llvm/trunk/lib/Target/PTX/PTXInstrInfo.td<br>
URL: <a href="http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PTX/PTXInstrInfo.td?rev=130356&r1=130355&r2=130356&view=diff" target="_blank">http://llvm.org/viewvc/llvm-project/llvm/trunk/lib/Target/PTX/PTXInstrInfo.td?rev=130356&r1=130355&r2=130356&view=diff</a><br>
==============================================================================<br>
--- llvm/trunk/lib/Target/PTX/PTXInstrInfo.td (original)<br>
+++ llvm/trunk/lib/Target/PTX/PTXInstrInfo.td Wed Apr 27 19:19:54 2011<br>
@@ -740,7 +740,7 @@<br>
def MOVU32ri<br>
: InstPTX<(outs RRegu32:$d), (ins i32imm:$a), "mov.u32\t$d, $a",<br>
[(set RRegu32:$d, imm:$a)]>;<br>
- def MOVU164ri<br>
+ def MOVU64ri<br>
: InstPTX<(outs RRegu64:$d), (ins i64imm:$a), "mov.u64\t$d, $a",<br>
[(set RRegu64:$d, imm:$a)]>;<br>
def MOVF32ri<br>
@@ -802,11 +802,11 @@<br>
[(set Preds:$d, (trunc RRegu64:$a))]>;<br>
def CVT_pred_f32<br>
- : InstPTX<(outs Preds:$d), (ins RRegf32:$a), "cvt.pred.f32\t$d, $a",<br>
+ : InstPTX<(outs Preds:$d), (ins RRegf32:$a), "cvt.rni.pred.f32\t$d, $a",<br>
[(set Preds:$d, (fp_to_uint RRegf32:$a))]>;<br>
def CVT_pred_f64<br>
- : InstPTX<(outs Preds:$d), (ins RRegf64:$a), "cvt.pred.f64\t$d, $a",<br>
+ : InstPTX<(outs Preds:$d), (ins RRegf64:$a), "cvt.rni.pred.f64\t$d, $a",<br>
[(set Preds:$d, (fp_to_uint RRegf64:$a))]>;<br>
// Conversion to u16<br>
@@ -824,11 +824,11 @@<br>
[(set RRegu16:$d, (trunc RRegu64:$a))]>;<br>
def CVT_u16_f32<br>
- : InstPTX<(outs RRegu16:$d), (ins RRegf32:$a), "cvt.u16.f32\t$d, $a",<br>
+ : InstPTX<(outs RRegu16:$d), (ins RRegf32:$a), "cvt.rni.u16.f32\t$d, $a",<br>
[(set RRegu16:$d, (fp_to_uint RRegf32:$a))]>;<br>
def CVT_u16_f64<br>
- : InstPTX<(outs RRegu16:$d), (ins RRegf64:$a), "cvt.u16.f64\t$d, $a",<br>
+ : InstPTX<(outs RRegu16:$d), (ins RRegf64:$a), "cvt.rni.u16.f64\t$d, $a",<br>
[(set RRegu16:$d, (fp_to_uint RRegf64:$a))]>;<br>
// Conversion to u32<br>
@@ -846,11 +846,11 @@<br>
[(set RRegu32:$d, (trunc RRegu64:$a))]>;<br>
def CVT_u32_f32<br>
- : InstPTX<(outs RRegu32:$d), (ins RRegf32:$a), "cvt.u32.f32\t$d, $a",<br>
+ : InstPTX<(outs RRegu32:$d), (ins RRegf32:$a), "cvt.rni.u32.f32\t$d, $a",<br>
[(set RRegu32:$d, (fp_to_uint RRegf32:$a))]>;<br>
def CVT_u32_f64<br>
- : InstPTX<(outs RRegu32:$d), (ins RRegf64:$a), "cvt.u32.f64\t$d, $a",<br>
+ : InstPTX<(outs RRegu32:$d), (ins RRegf64:$a), "cvt.rni.u32.f64\t$d, $a",<br>
[(set RRegu32:$d, (fp_to_uint RRegf64:$a))]>;<br>
// Conversion to u64<br>
@@ -868,51 +868,51 @@<br>
[(set RRegu64:$d, (zext RRegu32:$a))]>;<br>
def CVT_u64_f32<br>
- : InstPTX<(outs RRegu64:$d), (ins RRegf32:$a), "cvt.u64.f32\t$d, $a",<br>
+ : InstPTX<(outs RRegu64:$d), (ins RRegf32:$a), "cvt.rni.u64.f32\t$d, $a",<br>
[(set RRegu64:$d, (fp_to_uint RRegf32:$a))]>;<br>
def CVT_u64_f64<br>
- : InstPTX<(outs RRegu64:$d), (ins RRegf64:$a), "cvt.u64.f32\t$d, $a",<br>
+ : InstPTX<(outs RRegu64:$d), (ins RRegf64:$a), "cvt.rni.u64.f64\t$d, $a",<br>
[(set RRegu64:$d, (fp_to_uint RRegf64:$a))]>;<br>
// Conversion to f32<br>
def CVT_f32_pred<br>
- : InstPTX<(outs RRegf32:$d), (ins Preds:$a), "cvt.f32.pred\t$d, $a",<br>
+ : InstPTX<(outs RRegf32:$d), (ins Preds:$a), "cvt.rn.f32.pred\t$d, $a",<br>
[(set RRegf32:$d, (uint_to_fp Preds:$a))]>;<br>
def CVT_f32_u16<br>
- : InstPTX<(outs RRegf32:$d), (ins RRegu16:$a), "cvt.f32.u16\t$d, $a",<br>
+ : InstPTX<(outs RRegf32:$d), (ins RRegu16:$a), "cvt.rn.f32.u16\t$d, $a",<br>
[(set RRegf32:$d, (uint_to_fp RRegu16:$a))]>;<br>
def CVT_f32_u32<br>
- : InstPTX<(outs RRegf32:$d), (ins RRegu32:$a), "cvt.f32.u32\t$d, $a",<br>
+ : InstPTX<(outs RRegf32:$d), (ins RRegu32:$a), "cvt.rn.f32.u32\t$d, $a",<br>
[(set RRegf32:$d, (uint_to_fp RRegu32:$a))]>;<br>
def CVT_f32_u64<br>
- : InstPTX<(outs RRegf32:$d), (ins RRegu64:$a), "cvt.f32.u64\t$d, $a",<br>
+ : InstPTX<(outs RRegf32:$d), (ins RRegu64:$a), "cvt.rn.f32.u64\t$d, $a",<br>
[(set RRegf32:$d, (uint_to_fp RRegu64:$a))]>;<br>
def CVT_f32_f64<br>
- : InstPTX<(outs RRegf32:$d), (ins RRegf64:$a), "cvt.f32.f64\t$d, $a",<br>
+ : InstPTX<(outs RRegf32:$d), (ins RRegf64:$a), "cvt.rn.f32.f64\t$d, $a",<br>
[(set RRegf32:$d, (fround RRegf64:$a))]>;<br>
// Conversion to f64<br>
def CVT_f64_pred<br>
- : InstPTX<(outs RRegf64:$d), (ins Preds:$a), "cvt.f64.pred\t$d, $a",<br>
+ : InstPTX<(outs RRegf64:$d), (ins Preds:$a), "cvt.rn.f64.pred\t$d, $a",<br>
[(set RRegf64:$d, (uint_to_fp Preds:$a))]>;<br>
def CVT_f64_u16<br>
- : InstPTX<(outs RRegf64:$d), (ins RRegu16:$a), "cvt.f64.u16\t$d, $a",<br>
+ : InstPTX<(outs RRegf64:$d), (ins RRegu16:$a), "cvt.rn.f64.u16\t$d, $a",<br>
[(set RRegf64:$d, (uint_to_fp RRegu16:$a))]>;<br>
def CVT_f64_u32<br>
- : InstPTX<(outs RRegf64:$d), (ins RRegu32:$a), "cvt.f64.u32\t$d, $a",<br>
+ : InstPTX<(outs RRegf64:$d), (ins RRegu32:$a), "cvt.rn.f64.u32\t$d, $a",<br>
[(set RRegf64:$d, (uint_to_fp RRegu32:$a))]>;<br>
def CVT_f64_u64<br>
- : InstPTX<(outs RRegf64:$d), (ins RRegu64:$a), "cvt.f64.u64\t$d, $a",<br>
+ : InstPTX<(outs RRegf64:$d), (ins RRegu64:$a), "cvt.rn.f64.u64\t$d, $a",<br>
[(set RRegf64:$d, (uint_to_fp RRegu64:$a))]>;<br>
def CVT_f64_f32<br>
<br>
<br>
_______________________________________________<br>
llvm-commits mailing list<br>
<a href="mailto:llvm-commits@cs.uiuc.edu" target="_blank">llvm-commits@cs.uiuc.edu</a><br>
<a href="http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits" target="_blank">http://lists.cs.uiuc.edu/mailman/listinfo/llvm-commits</a><br>
<br>
<br>
</blockquote>
</div></div></blockquote></div><br><br clear="all"><br>-- <br><br><div>Thanks,</div><div><br></div><div>Justin Holewinski</div><br>