<html><head></head><body style="word-wrap: break-word; -webkit-nbsp-mode: space; -webkit-line-break: after-white-space; "><div><div>On Apr 12, 2011, at 12:41 PM, Nick Lewycky wrote:</div><br class="Apple-interchange-newline"><blockquote type="cite"><div class="gmail_quote">On 12 April 2011 08:55, Jim Grosbach <span dir="ltr"><<a href="mailto:grosbach@apple.com">grosbach@apple.com</a>></span> wrote:<br><blockquote class="gmail_quote" style="margin:0 0 0 .8ex;border-left:1px #ccc solid;padding-left:1ex;">
Hi Nick,<br>
<br>
clang is issuing a warning for this. Mind having a look?<br></blockquote><div><br></div><div>Sorry! I meant for counter to be a uint64_t, and updated that. Neither gcc nor clang warned when I built it this time, but I could imagine that it still might on a different platform. Let me know if it's not fixed past r129380.</div>
<div><br></div><div>Nick</div><div> </div><blockquote class="gmail_quote" style="margin-top: 0px; margin-right: 0px; margin-bottom: 0px; margin-left: 0.8ex; border-left-width: 1px; border-left-color: rgb(204, 204, 204); border-left-style: solid; padding-left: 1ex; position: static; z-index: auto; ">
<br>
llvm[2]: Compiling LineProfiling.c for Debug+Asserts build (PIC)<br>
/Volumes/Home/grosbaj/sources/llvm/runtime/libprofile/LineProfiling.c:32:25: warning:<br>
conversion specifies type 'unsigned long' but the argument has type<br>
'int64_t' (aka 'long long') [-Wformat]<br>
<div class="im"> printf("%s/%s:%u:%u %lu\n", dir, file, line, column, *counter);<br>
</div> ~~^ ~~~~~~~~<br>
%lld<br>
1 warning generated.<br>
<br>
(highlighting points to the "%lu" and "*counter" inputs)</blockquote></div></blockquote><br></div><div>Should the specifier in the printf be "%ull" (or maybe "%llu") to match the "unsigned long long"-ness of counter?</div><div><br></div><div>-- Marshall</div><div><br></div><br></body></html>